Review main Merged

57095[TASK] Deprecate T3_ERR_SV_ constants

Benni Mack CR +2 V +2 Normal +126 −8 updated 05/30/18, 19:50

Commit message

The following constants related to the Services in TYPO3 have been moved into AbstractService
as class constants, effectively moving them in the right context.

- T3_ERR_SV_GENERAL
- T3_ERR_SV_NOT_AVAIL
- T3_ERR_SV_WRONG_SUBTYPE
- T3_ERR_SV_NO_INPUT
- T3_ERR_SV_FILE_NOT_FOUND
- T3_ERR_SV_FILE_READ
- T3_ERR_SV_FILE_WRITE
- T3_ERR_SV_PROG_NOT_FOUND
- T3_ERR_SV_PROG_FAILED

The Extension scanner will detect usages of these constants. The constants will
be removed in TYPO3 v10.

Review

  • Code review CR +2
    • Andreas Kienast +2
    • Christian Kuhn +1
  • Verified V +2
    • Andreas Kienast +2
    • Christian Kuhn +1
    • TYPO3com +1 CI

Issues 1

Files 4

Review log 57

  1. Benni Mack uploaded patch set 1 05/30/18, 19:26

  2. TYPO3com voted on patch set 1 V -1 05/30/18, 19:26 Completed build in 08s on Wed, 30 May, 09:26 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-23913

  3. Andreas Kienast uploaded patch set 2 05/30/18, 19:39

  4. Christian Kuhn voted on patch set 2 V +1 CR +1 05/30/18, 19:45

  5. TYPO3com voted on patch set 2 V +1 05/30/18, 19:48 Completed build in 09m 18s on Wed, 30 May, 09:48 PM Test Summary: 31149 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-23916

  6. Andreas Kienast voted on patch set 2 V +2 CR +2 05/30/18, 19:50

  7. Andreas Kienast merged patch set 3 05/30/18, 19:50