Review main Abandoned

57101[BUGFIX] Use current scheme when linking across domains

Helmut Hummel CR 0 V 0 Easy +1 −3 updated 05/31/18, 10:57

Commit message

Instead of defaulting to http:// for cross domain linking,
we now check if current connection is https and use
https then as default.

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 1

Review log 34

  1. Helmut Hummel uploaded patch set 1 05/31/18, 10:39

  2. TYPO3com voted on patch set 1 V -1 05/31/18, 10:39 Completed build in 07s on Thu, 31 May, 12:39 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-23939

  3. Christian Kuhn commented on patch set 1 05/31/18, 10:55

    this looks identical to https://review.typo3.org/#/c/57082/
  4. Helmut Hummel abandoned the change 05/31/18, 10:57

    > this looks identical to https://review.typo3.org/#/c/57082/ wow, thanks. I looked for tickets mentioning this, but didn't find any