Review TYPO3_8-7 Merged

57105[BUGFIX] Handle access restrictions on recycler search

Frans Saris CR +2 V +2 Easy +21 −8 updated 05/31/18, 18:26

Commit message

Fetching a parent folder may throws an error if the user hasn't
access to the parent. This exception needs to be caught and the
search for an existing recycler folder needs to be stopped
immediately.

Furthermore the patch removes the comparison with the root level
folder but checks the parent folder doesn't equal the folder itself.

Another loop is fixed by calling moveFile on the correct
ResourceStorge and not the current one.

Review

  • Code review CR +2
    • Frans Saris +2
  • Verified V +2
    • Frans Saris +2

Issues 2

Files 1

Review log 34

  1. Frans Saris commented on patch set 1 05/31/18, 18:12

    Cherry Picked from branch master.
  2. Frans Saris voted on patch set 1 V +2 CR +2 05/31/18, 18:14

  3. Frans Saris merged patch set 2 05/31/18, 18:14

  4. TYPO3com voted on patch set 1 V +1 05/31/18, 18:26 Completed build in 14m 09s on Thu, 31 May, 08:26 PM Test Summary: 58350 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC87-2526