Review main Merged

57107[BUGFIX] Fix inSet implementation for sqlite

Susi Moog CR +2 V +2 Easy +29 −15 updated 05/31/18, 23:10

Commit message

For SQLite inSet was implemented with a "like" substitution
which had various bugs. That implementation has
now been substituted with an "instr" implementation.

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Benni Mack +1
  • Verified V +2
    • Christian Kuhn +2
    • Benni Mack +1
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 710

  1. Susi Moog uploaded patch set 1 05/31/18, 19:25

  2. TYPO3com voted on patch set 1 V -1 05/31/18, 19:31 Completed build in 06m 46s on Thu, 31 May, 09:31 PM Test Summary: 6 of 31394 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-23959

  3. Susi Moog uploaded patch set 2 05/31/18, 19:39

  4. TYPO3com voted on patch set 2 V +1 05/31/18, 19:46 Completed build in 06m 52s on Thu, 31 May, 09:46 PM Test Summary: 31147 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-23960

  5. Benni Mack commented on patch set 3 05/31/18, 20:01

    Published edit on patch set 2.
  6. Benni Mack voted on patch set 3 V +1 CR +1 05/31/18, 20:03

  7. Christian Kuhn voted on patch set 3 V +1 CR +1 05/31/18, 20:04

  8. Christian Kuhn voted on patch set 3 V +2 CR +2 05/31/18, 20:04

  9. TYPO3com voted on patch set 3 V +1 05/31/18, 20:08 Completed build in 07m 09s on Thu, 31 May, 10:08 PM Test Summary: 31147 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-23961

  10. Benni Mack merged patch set 4 05/31/18, 23:10