Review TYPO3_8-7 Merged

57109[BUGFIX] Correctly resolve RTE preset configuration for link browser

Tymoteusz Motylewski CR +2 V +2 Easy +10 −1 updated 06/01/18, 21:44

Commit message

Replaces hardcoded RTE configuration in BrowseLinksController
with one resolved by Formengine when rendering a field.
This takes into account e.g. column overrides.

The RTE configuration preset name is now kept by Formengine in
['processedTca']['columns'][$fieldName]['config']['richtextConfigurationName']

Then it's being passed as parameter P[richtextConfigurationName] from RTE field
to the BrowseinksController

Review

  • Code review CR +2
    • Tymoteusz Motylewski +2
  • Verified V +2
    • Tymoteusz Motylewski +2
    • TYPO3com +1 CI

Issues 1

Files 4

Review log 34

  1. Tymoteusz Motylewski commented on patch set 1 06/01/18, 09:25

    Cherry Picked from branch master.
  2. TYPO3com voted on patch set 1 V +1 06/01/18, 09:34 Completed build in 08m 42s on Fri, 1 Jun, 11:34 AM Test Summary: 58350 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC87-2528

  3. Tymoteusz Motylewski voted on patch set 1 V +2 CR +2 06/01/18, 21:43

  4. Tymoteusz Motylewski merged patch set 2 06/01/18, 21:44