Review main Merged

57112[BUGFIX] CleanerTask processes all FileResource Fields

Sven Juergens CR +2 V +2 Easy +0 −1 updated 10/26/18, 12:09

Commit message

By removing an errorous break in a loop, all FileResource Fields are found
and therefor all connected files can be deleted.

Review

  • Code review CR +2
    • Benni Mack +2
    • Frank Nägler +1
    • Andreas Kienast +1
  • Verified V +2
    • Benni Mack +2
    • Christian Kuhn +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 1013

  1. Sven Juergens uploaded patch set 1 06/01/18, 13:19

  2. TYPO3com voted on patch set 1 V +1 06/01/18, 13:26 Completed build in 07m 02s on Fri, 1 Jun, 03:26 PM Test Summary: 31120 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-23988

  3. Anja Leichsenring updated the commit message in patch set 2 06/01/18, 13:34

  4. TYPO3com voted on patch set 2 V +1 06/01/18, 13:45 Completed build in 11m 17s on Fri, 1 Jun, 03:45 PM Test Summary: 31120 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-23993

  5. Anja Leichsenring updated the commit message in patch set 3 06/01/18, 14:51

  6. TYPO3com voted on patch set 3 V +1 06/01/18, 14:58 Completed build in 07m 09s on Fri, 1 Jun, 04:58 PM Test Summary: 31120 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-23997

  7. Frank Nägler voted on patch set 3 CR +1 06/08/18, 13:10

  8. Frank Nägler commented on patch set 3 06/08/18, 13:12

    thanks for the patch, can you add some tests to make this area more stable?
  9. Andreas Kienast commented on patch set 3 CR +1 06/08/18, 13:16

    Looks plausible, but as Frank already suggested, tests are very welcome here.
  10. Christian Kuhn voted on patch set 3 V +1 10/26/18, 12:09

  11. Benni Mack voted on patch set 3 V +2 CR +2 10/26/18, 12:09

  12. Benni Mack merged patch set 4 10/26/18, 12:09

  13. Benni Mack commented on patch set 4 10/26/18, 12:09

    Cherry Picked This patchset was cherry picked to branch TYPO3_8-7 as commit 1f103bd4f6e64f8ab0287c41e52b1f7dd1c7cc93