Review main Merged

57118[BUGFIX] Avoid fatal error in scheduler

Benni Mack CR +2 V +2 Easy +7 −0 updated 06/04/18, 18:56

Commit message

The scheduler object cleans up execution
arrays on instantiation. Due to the PSR-3
refactoring, the logger is instantiated
after the constructor is called - resulting
in a fatal error ("Call to member function info()
on null") when cleaning up the execution array.

The patch manually instantiates a logger if
there isn't one already.

Review

  • Code review CR +2
    • Wouter Wolters +2
    • Oliver Klee +1
    • Daniel Gorges +1
    • Jörg Bösche +1
    • Steffen Frese +1
  • Verified V +2
    • Wouter Wolters +2
    • Daniel Gorges +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 89

  1. Benni Mack uploaded patch set 1 06/04/18, 06:49

  2. Wouter Wolters voted on patch set 1 CR +1 06/04/18, 06:56

  3. TYPO3com voted on patch set 1 V +1 06/04/18, 06:58 Completed build in 08m 08s on Mon, 4 Jun, 08:58 AM Test Summary: 31143 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-24015

  4. Oliver Klee voted on patch set 1 CR +1 06/04/18, 07:09

  5. Jörg Bösche voted on patch set 1 CR +1 06/04/18, 07:54

  6. Daniel Gorges voted on patch set 1 V +1 CR +1 06/04/18, 09:08

  7. Steffen Frese voted on patch set 1 CR +1 06/04/18, 09:49

  8. Wouter Wolters voted on patch set 1 V +2 CR +2 06/04/18, 18:56

  9. Wouter Wolters merged patch set 2 06/04/18, 18:56