57125[TASK] Use a dedicated logger for E_USER_DEPRECATION
Commit message
Review
-
Code review CR +2
- Markus Klein +2
- Mathias Schreiber +1
- Daniel Goerz +1
- Helmut Hummel +1
-
Verified V +2
- Markus Klein +2
- Mathias Schreiber +1
- Helmut Hummel +1
- TYPO3com +1 CI
Issues 1
Files 2
Review log 1519
-
Markus Klein uploaded patch set 1 06/04/18, 20:32
-
TYPO3com voted on patch set 1 V -1 06/04/18, 20:32 Completed build in 06s on Mon, 4 Jun, 10:32 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-24055
-
Markus Klein uploaded patch set 2 06/12/18, 09:48
-
TYPO3com voted on patch set 2 V -1 06/12/18, 09:49 Completed build in 07s on Tue, 12 Jun, 11:49 AM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-24354
-
Markus Klein commented on patch set 2 CR -1 06/12/18, 09:49
requires https://review.typo3.org/57198 -
Helmut Hummel commented on patch set 2 V +1 CR +1 06/13/18, 09:09
I think this solves the most pressing issues. Could probably amended a bit once we introduced the notion of channels for logging -
Markus Klein rebased onto patch set 3 07/19/18, 07:15
-
TYPO3com voted on patch set 3 V -1 07/19/18, 07:16 Completed build in 15s on Thu, 19 Jul, 09:16 AM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-25542
-
Helmut Hummel uploaded patch set 4 07/19/18, 11:06
-
Helmut Hummel voted on patch set 4 V +1 CR +1 07/19/18, 11:07
-
TYPO3com voted on patch set 4 V +1 07/19/18, 11:13 Completed build in 07m 23s on Thu, 19 Jul, 01:13 PM Test Summary: 33375 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-25548
-
Markus Klein commented on patch set 4 07/19/18, 14:57
Thanks Helmut for improving -
Daniel Goerz voted on patch set 4 CR +1 07/19/18, 15:33
-
Mathias Schreiber commented on patch set 4 V +1 CR -1 07/19/18, 15:36
DefaultConfiguration.php:1335do we keep this comma on purpose? If it's a mistake, let me know and I'll remove it. -
Markus Klein commented on patch set 4 07/19/18, 15:41
DefaultConfiguration.php:1335Reply Unresolvedwell, I don't know. ;-) PHP does not care, nor do I. My PHPStorm adds them automatically AFAIK -
Mathias Schreiber voted on patch set 4 CR +1 07/19/18, 15:41
-
Mathias Schreiber commented on patch set 4 07/19/18, 15:41
fair enough -
Markus Klein commented on patch set 4 V +2 CR +2 07/19/18, 15:46
Thanks! -
Markus Klein merged patch set 5 07/19/18, 15:46