Review main Merged

57132[BUGFIX] Have correct test class namespaces

Christian Kuhn CR +2 V +2 Hard +171 −81 updated 06/06/18, 18:58

Commit message

phpunit tends to execute test case files even if the
file comes with a broken namespace and can't be autoloaded.

The patch hopefully fixes all test case files that are
positioned in a wrong folder, has an otherwise broken
namespace or is not yet registered as psr-4 require-dev.

Review

  • Code review CR +2
    • Wouter Wolters +2
    • Anja Leichsenring +1
    • Benni Mack +1
  • Verified V +2
    • Wouter Wolters +2
    • Anja Leichsenring +1
    • Benni Mack +1
    • TYPO3com +1 CI

Issues 1

Files 51

Show 31 more files

Review log 78

  1. Christian Kuhn uploaded patch set 1 06/06/18, 18:40

  2. TYPO3com voted on patch set 1 V +1 06/06/18, 18:47 Completed build in 06m 49s on Wed, 6 Jun, 08:47 PM Test Summary: 31143 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-24093

  3. Benni Mack voted on patch set 1 CR +1 06/06/18, 18:50

  4. Wouter Wolters voted on patch set 1 V +1 CR +1 06/06/18, 18:51

  5. Benni Mack voted on patch set 1 V +1 06/06/18, 18:55

  6. Anja Leichsenring voted on patch set 1 V +1 CR +1 06/06/18, 18:57

  7. Wouter Wolters voted on patch set 1 V +2 CR +2 06/06/18, 18:58

  8. Wouter Wolters merged patch set 2 06/06/18, 18:58