57133[TASK] Streamline functional data handling tests
Commit message
Review
-
Code review CR +2
- Christian Kuhn +2
- Wouter Wolters +1
- Benni Mack +1
-
Verified V +2
- Christian Kuhn +2
- Benni Mack +1
- TYPO3com +1 CI
Issues 1
Files 6
- typo3/sysext/core/Tests/Functional/DataHandling/FlexformIrre/DataSet/LiveDefaultElements.csv+2 −2
- typo3/sysext/core/Tests/Functional/DataHandling/FlexformIrre/ActionTest.phprenamed+9 −11
- typo3/sysext/core/Tests/Functional/DataHandling/Group/AbstractActionTestCase.php+0 −18
- typo3/sysext/core/Tests/Functional/DataHandling/ManyToMany/AbstractActionTestCase.php+0 −16
- typo3/sysext/core/Tests/Functional/DataHandling/Select/AbstractActionTestCase.php+0 −18
- typo3/sysext/workspaces/Tests/Functional/DataHandling/ManyToMany/AbstractActionTestCase.php+0 −4
Review log 79
-
Christian Kuhn uploaded patch set 1 06/06/18, 20:10
-
Christian Kuhn commented on patch set 1 06/06/18, 20:11
aligned with olly to do it like that. -
TYPO3com voted on patch set 1 V -1 06/06/18, 20:19 Completed build in 08m 44s on Wed, 6 Jun, 10:19 PM Test Summary: 31109 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-24095
-
Christian Kuhn uploaded patch set 2 06/06/18, 20:42
-
TYPO3com voted on patch set 2 V +1 06/06/18, 20:50 Completed build in 08m 07s on Wed, 6 Jun, 10:50 PM Test Summary: 31109 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-24096
-
Benni Mack voted on patch set 2 V +1 CR +1 06/06/18, 20:53
-
Christian Kuhn commented on patch set 2 V +2 CR +2 06/06/18, 22:13
taking the freedom to merge this, even with a missing vote: non-risky test change only, aligned with olly and benni, blocks another patch on my side -
Christian Kuhn merged patch set 3 06/06/18, 22:13
-
Wouter Wolters commented on patch set 3 CR +1 06/06/18, 22:29
Post +1