Review main Merged

57133[TASK] Streamline functional data handling tests

Christian Kuhn CR +2 V +2 Normal +11 −69 updated 06/06/18, 22:29

Commit message

The various "AbstractActionTestCase" classes of the functional
data handling tests only prepare the scenario, while the extending
Test classes of ext:core and ext:workspaces then call parent and
add assertions.
The abstract test preparations thus must not have @test annotations,
they would be executed as casual tests without asserting anything
useful.
The patch removes those obsolete @test annotations and fixes
another test case that had wrong wrong naming and was not executed
for a while.

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Wouter Wolters +1
    • Benni Mack +1
  • Verified V +2
    • Christian Kuhn +2
    • Benni Mack +1
    • TYPO3com +1 CI

Issues 1

Files 6

Review log 79

  1. Christian Kuhn uploaded patch set 1 06/06/18, 20:10

  2. Christian Kuhn commented on patch set 1 06/06/18, 20:11

    aligned with olly to do it like that.
  3. TYPO3com voted on patch set 1 V -1 06/06/18, 20:19 Completed build in 08m 44s on Wed, 6 Jun, 10:19 PM Test Summary: 31109 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-24095

  4. Christian Kuhn uploaded patch set 2 06/06/18, 20:42

  5. TYPO3com voted on patch set 2 V +1 06/06/18, 20:50 Completed build in 08m 07s on Wed, 6 Jun, 10:50 PM Test Summary: 31109 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-24096

  6. Benni Mack voted on patch set 2 V +1 CR +1 06/06/18, 20:53

  7. Christian Kuhn commented on patch set 2 V +2 CR +2 06/06/18, 22:13

    taking the freedom to merge this, even with a missing vote: non-risky test change only, aligned with olly and benni, blocks another patch on my side
  8. Christian Kuhn merged patch set 3 06/06/18, 22:13

  9. Wouter Wolters commented on patch set 3 CR +1 06/06/18, 22:29

    Post +1