Review main Abandoned

57135[BUGFIX] Correctly instantiate FE users "image"-property as ObjectSto…

TYPO3com CR 0 V 0 Easy +1 −0 updated 06/08/18, 09:51

Commit message

…rage

Reason: If another object is accessing the property and expects an
ObjectStorage, then functions like foreach will cause an error if the
property is NULL.

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 1

Review log 24

  1. TYPO3com uploaded patch set 1 06/07/18, 09:12

  2. TYPO3com voted on patch set 1 V -1 06/07/18, 09:19 Completed build in 07m 02s on Thu, 7 Jun, 11:19 AM Test Summary: 3 of 31356 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-24105

  3. Frank Nägler commented on patch set 1 CR -1 06/08/18, 09:50

    Thank you for your contribution, but we will not merge this patch. The null return is an intended behavior and there is also a test which exactly check this behavior. Another reason is, that this will break existing implementations which checks for "null". To solve your problem you should use a null check in your implementation. For the reasons above I will abandon this patch.
  4. Frank Nägler abandoned the change 06/08/18, 09:51