Review main Merged

57136[BUGFIX] Fix broken additional fields for garbarge collection task

Frank Nägler CR +2 V +2 Easy +3 −30 updated 06/09/18, 20:56

Commit message

The new IpAnonymizationAdditionalFieldProvider introduced the same
JavaScript variable which breaks the garbage collection task.
The JavaScript initialization has been removed and the field provider 
simplified.

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Anja Leichsenring +1
  • Verified V +2
    • Christian Kuhn +2
    • Anja Leichsenring +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 1013

  1. Frank Nägler uploaded patch set 1 06/07/18, 09:42

  2. TYPO3com voted on patch set 1 V +1 06/07/18, 09:49 Completed build in 07m 14s on Thu, 7 Jun, 11:49 AM Test Summary: 31109 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-24106

  3. Mathias Brodala commented on patch set 1 06/07/18, 09:57

    Shouldn't this be done for 8.7 and 7.6 too?
  4. Frank Nägler updated the commit message in patch set 2 06/07/18, 10:25

  5. TYPO3com voted on patch set 2 V +1 06/07/18, 10:32 Completed build in 06m 57s on Thu, 7 Jun, 12:32 PM Test Summary: 31109 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-24108

  6. Susi Moog voted on patch set 2 V +1 CR +1 06/09/18, 14:10

  7. Susi Moog updated the commit message in patch set 3 06/09/18, 14:51

  8. TYPO3com voted on patch set 3 V +1 06/09/18, 14:59 Completed build in 07m 34s on Sat, 9 Jun, 04:59 PM Test Summary: 32692 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-24209

  9. Anja Leichsenring voted on patch set 3 V +1 CR +1 06/09/18, 16:01

  10. Oliver Hader commented on patch set 3 06/09/18, 16:49

    How to test?
  11. Christian Kuhn voted on patch set 3 V +2 CR +2 06/09/18, 20:56

  12. Christian Kuhn merged patch set 4 06/09/18, 20:56

  13. Christian Kuhn commented on patch set 4 06/09/18, 20:56

    Cherry Picked This patchset was cherry picked to branch TYPO3_8-7 as commit e495ad8f5bee443e0f4698d4f664dca58ef97beb