Review main Merged

57140[TASK] Force string values in impexp exports

Christian Kuhn CR +2 V +2 Nightmare +2206 −2178 updated 06/07/18, 15:58

Commit message

Method BackendUtility::getRecord() returns strings or integer
values for number columns like int / bigint. This detail depends
on the underlying driver, for instance mysqli returns integers
for those fields, while native pdo_mysql and our pdo_pgsql setup
return strings for everything.

This leads to different xml files when exporting records depending
on driver, since GeneralUtility::array2xml() may add type="integer".
That's especially nasty for the functional export tests and is one
reason we have to maintain dedicated xml fixture files per db driver.

During import, the type value does not matter, it needs to be able
to cope with both variants anyway.

The patch now just forces strings for all to-be-exported row values.

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Anja Leichsenring +1
    • Benni Mack +1
  • Verified V +2
    • Christian Kuhn +2
    • Anja Leichsenring +1
    • Benni Mack +1
    • TYPO3com +1 CI

Issues 1

Files 41

Show 21 more files

Review log 1422

  1. Christian Kuhn uploaded patch set 1 06/07/18, 13:43

  2. Christian Kuhn commented on patch set 1 CR -2 06/07/18, 13:43

    this will fail on bamboo in export related functionals for now
  3. Christian Kuhn uploaded patch set 2 06/07/18, 13:48

  4. TYPO3com voted on patch set 1 V -1 06/07/18, 13:50 Completed build in 06m 58s on Thu, 7 Jun, 03:50 PM Test Summary: 7 of 31356 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-24116

  5. TYPO3com voted on patch set 2 V -1 06/07/18, 13:55 Completed build in 07m 20s on Thu, 7 Jun, 03:55 PM Test Summary: 7 of 31356 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-24117

  6. Christian Kuhn uploaded patch set 3 06/07/18, 13:59

  7. Christian Kuhn uploaded patch set 4 06/07/18, 14:05

  8. TYPO3com voted on patch set 3 V -1 06/07/18, 14:07 Completed build in 07m 06s on Thu, 7 Jun, 04:07 PM Test Summary: 8 of 31356 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-24118

  9. TYPO3com voted on patch set 4 V -1 06/07/18, 14:12 Completed build in 07m 01s on Thu, 7 Jun, 04:12 PM Test Summary: 8 of 31356 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-24119

  10. Christian Kuhn uploaded patch set 5 06/07/18, 14:51

  11. TYPO3com voted on patch set 5 V -1 06/07/18, 14:51 Completed build in 05s on Thu, 7 Jun, 04:51 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-24121

  12. Christian Kuhn uploaded patch set 6 06/07/18, 14:54

  13. TYPO3com voted on patch set 6 V -1 06/07/18, 15:02 Completed build in 07m 10s on Thu, 7 Jun, 05:02 PM Test Summary: 10 of 31482 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-24122

  14. Christian Kuhn uploaded patch set 7 06/07/18, 15:12

  15. TYPO3com voted on patch set 7 V -1 06/07/18, 15:19 Completed build in 07m 17s on Thu, 7 Jun, 05:19 PM Test Summary: 10 of 31482 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-24123

  16. Christian Kuhn uploaded patch set 8 06/07/18, 15:40

  17. Benni Mack voted on patch set 8 V +1 CR +1 06/07/18, 15:48

  18. Christian Kuhn voted on patch set 8 CR 0 06/07/18, 15:48

  19. TYPO3com voted on patch set 8 V +1 06/07/18, 15:48 Completed build in 07m 31s on Thu, 7 Jun, 05:48 PM Test Summary: 31235 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-24125

  20. Anja Leichsenring voted on patch set 8 V +1 CR +1 06/07/18, 15:57

  21. Christian Kuhn voted on patch set 8 V +2 CR +2 06/07/18, 15:58

  22. Christian Kuhn merged patch set 9 06/07/18, 15:58