57140[TASK] Force string values in impexp exports
Commit message
Review
-
Code review CR +2
- Christian Kuhn +2
- Anja Leichsenring +1
- Benni Mack +1
-
Verified V +2
- Christian Kuhn +2
- Anja Leichsenring +1
- Benni Mack +1
- TYPO3com +1 CI
Issues 1
Files 41
- typo3/sysext/core/Tests/Functional/DataHandling/FlexformIrre/DataSet/LiveDefaultElements.csv+2 −2
- typo3/sysext/impexp/Classes/Export.php+7 −0
- typo3/sysext/impexp/Tests/Functional/Export/GroupFileAndFileReferenceItemInFlexFormTest.php+3 −2
- typo3/sysext/impexp/Tests/Functional/Export/GroupFileAndFileReferenceItemTest.php+3 −2
- typo3/sysext/impexp/Tests/Functional/Export/IrreTutorialRecordsTest.php+2 −1
- typo3/sysext/impexp/Tests/Functional/Export/PagesAndTtContentTest.php+5 −4
- typo3/sysext/impexp/Tests/Functional/Export/PagesAndTtContentWithImagesTest.php+6 −5
- typo3/sysext/impexp/Tests/Functional/Fixtures/XmlExports/mssql/impexp-group-file-and-file_reference-item-but-images-not-included.xml+24 −24
- typo3/sysext/impexp/Tests/Functional/Fixtures/XmlExports/mssql/impexp-group-file-and-file_reference-item-in-ff.xml+30 −30
- typo3/sysext/impexp/Tests/Functional/Fixtures/XmlExports/mssql/impexp-group-file-and-file_reference-item.xml+24 −24
- typo3/sysext/impexp/Tests/Functional/Fixtures/XmlExports/mssql/irre-records.xml+430 −430
- typo3/sysext/impexp/Tests/Functional/Fixtures/XmlExports/mssql/pages-and-ttcontent-with-corrupt-image.xml+54 −54
- typo3/sysext/impexp/Tests/Functional/Fixtures/XmlExports/mssql/pages-and-ttcontent-with-image-but-not-included.xml+54 −54
- typo3/sysext/impexp/Tests/Functional/Fixtures/XmlExports/mssql/pages-and-ttcontent-with-image.xml+54 −54
- typo3/sysext/impexp/Tests/Functional/Fixtures/XmlExports/mssql/pages-and-ttcontent.xml+35 −35
- typo3/sysext/impexp/Tests/Functional/Fixtures/XmlExports/mysql/impexp-group-file-and-file_reference-item-but-images-not-included.xml+24 −24
- typo3/sysext/impexp/Tests/Functional/Fixtures/XmlExports/mysql/impexp-group-file-and-file_reference-item-in-ff.xml+31 −31
- typo3/sysext/impexp/Tests/Functional/Fixtures/XmlExports/mysql/impexp-group-file-and-file_reference-item.xml+24 −24
- typo3/sysext/impexp/Tests/Functional/Fixtures/XmlExports/mysql/irre-records.xml+429 −429
- typo3/sysext/impexp/Tests/Functional/Fixtures/XmlExports/mysql/pages-and-ttcontent-with-corrupt-image.xml+54 −54
Show 21 more files
- typo3/sysext/impexp/Tests/Functional/Fixtures/XmlExports/mysql/pages-and-ttcontent-with-image-but-not-included.xml+54 −54
- typo3/sysext/impexp/Tests/Functional/Fixtures/XmlExports/mysql/pages-and-ttcontent-with-image.xml+54 −54
- typo3/sysext/impexp/Tests/Functional/Fixtures/XmlExports/mysql/pages-and-ttcontent.xml+37 −37
- typo3/sysext/impexp/Tests/Functional/Fixtures/XmlExports/postgresql/impexp-group-file-and-file_reference-item-but-images-not-included.xml+1 −1
- typo3/sysext/impexp/Tests/Functional/Fixtures/XmlExports/postgresql/impexp-group-file-and-file_reference-item-in-ff.xml+1 −1
- typo3/sysext/impexp/Tests/Functional/Fixtures/XmlExports/postgresql/impexp-group-file-and-file_reference-item.xml+1 −1
- typo3/sysext/impexp/Tests/Functional/Fixtures/XmlExports/postgresql/irre-records.xml+1 −1
- typo3/sysext/impexp/Tests/Functional/Fixtures/XmlExports/postgresql/pages-and-ttcontent-with-corrupt-image.xml+1 −1
- typo3/sysext/impexp/Tests/Functional/Fixtures/XmlExports/postgresql/pages-and-ttcontent-with-image-but-not-included.xml+1 −1
- typo3/sysext/impexp/Tests/Functional/Fixtures/XmlExports/postgresql/pages-and-ttcontent-with-image.xml+1 −1
- typo3/sysext/impexp/Tests/Functional/Fixtures/XmlExports/postgresql/pages-and-ttcontent.xml+1 −1
- typo3/sysext/impexp/Tests/Functional/Fixtures/XmlImports/impexp-group-file-and-file_reference-item-but-images-not-included.xml+24 −24
- typo3/sysext/impexp/Tests/Functional/Fixtures/XmlImports/impexp-group-file-and-file_reference-item-in-ff.xml+31 −31
- typo3/sysext/impexp/Tests/Functional/Fixtures/XmlImports/impexp-group-file-and-file_reference-item.xml+24 −24
- typo3/sysext/impexp/Tests/Functional/Fixtures/XmlImports/irre-records.xml+417 −417
- typo3/sysext/impexp/Tests/Functional/Fixtures/XmlImports/pages-and-ttcontent-with-image-but-not-included.xml+54 −54
- typo3/sysext/impexp/Tests/Functional/Fixtures/XmlImports/pages-and-ttcontent-with-image.xml+54 −54
- typo3/sysext/impexp/Tests/Functional/Fixtures/XmlImports/pages-and-ttcontent-with-rte-image-n-file-link.xml+38 −38
- typo3/sysext/impexp/Tests/Functional/Fixtures/XmlImports/pages-and-ttcontent-with-two-images.xml+63 −63
- typo3/sysext/impexp/Tests/Functional/Fixtures/XmlImports/pages-and-ttcontent.xml+36 −36
- typo3/sysext/impexp/Tests/Functional/AbstractImportExportTestCase.php+17 −1
Review log 1422
-
Christian Kuhn uploaded patch set 1 06/07/18, 13:43
-
Christian Kuhn commented on patch set 1 CR -2 06/07/18, 13:43
this will fail on bamboo in export related functionals for now -
Christian Kuhn uploaded patch set 2 06/07/18, 13:48
-
TYPO3com voted on patch set 1 V -1 06/07/18, 13:50 Completed build in 06m 58s on Thu, 7 Jun, 03:50 PM Test Summary: 7 of 31356 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-24116
-
TYPO3com voted on patch set 2 V -1 06/07/18, 13:55 Completed build in 07m 20s on Thu, 7 Jun, 03:55 PM Test Summary: 7 of 31356 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-24117
-
Christian Kuhn uploaded patch set 3 06/07/18, 13:59
-
Christian Kuhn uploaded patch set 4 06/07/18, 14:05
-
TYPO3com voted on patch set 3 V -1 06/07/18, 14:07 Completed build in 07m 06s on Thu, 7 Jun, 04:07 PM Test Summary: 8 of 31356 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-24118
-
TYPO3com voted on patch set 4 V -1 06/07/18, 14:12 Completed build in 07m 01s on Thu, 7 Jun, 04:12 PM Test Summary: 8 of 31356 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-24119
-
Christian Kuhn uploaded patch set 5 06/07/18, 14:51
-
TYPO3com voted on patch set 5 V -1 06/07/18, 14:51 Completed build in 05s on Thu, 7 Jun, 04:51 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-24121
-
Christian Kuhn uploaded patch set 6 06/07/18, 14:54
-
TYPO3com voted on patch set 6 V -1 06/07/18, 15:02 Completed build in 07m 10s on Thu, 7 Jun, 05:02 PM Test Summary: 10 of 31482 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-24122
-
Christian Kuhn uploaded patch set 7 06/07/18, 15:12
-
TYPO3com voted on patch set 7 V -1 06/07/18, 15:19 Completed build in 07m 17s on Thu, 7 Jun, 05:19 PM Test Summary: 10 of 31482 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-24123
-
Christian Kuhn uploaded patch set 8 06/07/18, 15:40
-
Benni Mack voted on patch set 8 V +1 CR +1 06/07/18, 15:48
-
Christian Kuhn voted on patch set 8 CR 0 06/07/18, 15:48
-
TYPO3com voted on patch set 8 V +1 06/07/18, 15:48 Completed build in 07m 31s on Thu, 7 Jun, 05:48 PM Test Summary: 31235 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-24125
-
Anja Leichsenring voted on patch set 8 V +1 CR +1 06/07/18, 15:57
-
Christian Kuhn voted on patch set 8 V +2 CR +2 06/07/18, 15:58
-
Christian Kuhn merged patch set 9 06/07/18, 15:58