Review main Merged

57141[TASK] Align impexp functional export tests between db engines

Christian Kuhn CR +2 V +2 Impossible +384 −10915 updated 06/21/18, 10:39

Commit message

The ext:impexp related functional export tests compare
with different target .xml file exports depending on
the used db engine. This is ugly and pain to maintain.

The patch aligns last differences between the generated
exports by fixing sorting bugs in fixture db rows and adding
an explicit order by at test preparation stage.
Additionally, a column type bug in irre_tutorial fixture
extension got resolved.

The different .xml export file comparison fixtures per
db engine are then merged into one and the split logic
within tests removed.

Review

  • Code review CR +2
    • Wouter Wolters +2
    • Anja Leichsenring +1
  • Verified V +2
    • Wouter Wolters +2
    • Anja Leichsenring +1

Issues 1

Files 33

Show 13 more files

Review log 1521

  1. Christian Kuhn uploaded patch set 1 06/07/18, 17:38

  2. TYPO3com voted on patch set 1 V +1 06/07/18, 17:45 Completed build in 07m 07s on Thu, 7 Jun, 07:45 PM Test Summary: 31235 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-24127

  3. Christian Kuhn uploaded patch set 2 06/07/18, 17:46

  4. Christian Kuhn voted on patch set 2 CR -2 06/07/18, 17:47

  5. TYPO3com voted on patch set 2 V +1 06/07/18, 17:55 Completed build in 08m 17s on Thu, 7 Jun, 07:55 PM Test Summary: 31235 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-24128

  6. Christian Kuhn uploaded patch set 3 06/07/18, 18:05

  7. TYPO3com voted on patch set 3 V -1 06/07/18, 18:11 Completed build in 06m 27s on Thu, 7 Jun, 08:11 PM Test Summary: 4 of 31482 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-24130

  8. Christian Kuhn uploaded patch set 4 06/07/18, 18:16

  9. TYPO3com voted on patch set 4 V -1 06/07/18, 18:24 Completed build in 07m 39s on Thu, 7 Jun, 08:24 PM Test Summary: 1 of 31483 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-24132

  10. Christian Kuhn updated the commit message in patch set 5 06/07/18, 18:34

  11. Christian Kuhn voted on patch set 5 CR 0 06/07/18, 18:34

  12. Wouter Wolters voted on patch set 5 CR +1 06/07/18, 18:38

  13. Anja Leichsenring updated the commit message in patch set 6 06/07/18, 18:38

  14. TYPO3com voted on patch set 5 V +1 06/07/18, 18:41 Completed build in 07m 18s on Thu, 7 Jun, 08:41 PM Test Summary: 31235 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-24134

  15. Anja Leichsenring voted on patch set 6 V +1 CR +1 06/07/18, 18:41

  16. Wouter Wolters voted on patch set 6 CR +1 06/07/18, 18:42

  17. Wouter Wolters voted on patch set 6 V +2 CR +2 06/07/18, 18:43

  18. Wouter Wolters merged patch set 7 06/07/18, 18:43

  19. TYPO3com voted on patch set 6 V +1 06/07/18, 18:45 Completed build in 07m 12s on Thu, 7 Jun, 08:45 PM Test Summary: 31235 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-24135

  20. Tymoteusz Motylewski commented on patch set 7 06/21/18, 09:18

    post -1. The text column doesn't support default values. This break tests on my machine SQL Error for table "tx_irretutorial_1nff_price": An exception occurred while executing 'INSERT INTO `tx_irretutorial_1nff_price`Field 'price' doesn't have a default value I have no idea yet why it does work on bamboo. As a workaround we can change the coulumn to varchar or remove not null.
  21. Tymoteusz Motylewski commented on patch set 7 06/21/18, 10:39

    The issue is that tests are executed on mysql with sql mode set to: sql_mode NO_AUTO_CREATE_USER,NO_ENGINE_SUBSTITUTION while by default mysql 5.7 has: ONLY_FULL_GROUP_BY,STRICT_TRANS_TABLES,NO_ZERO_IN_DATE,NO_ZERO_DATE,ERROR_FOR_DIVISION_BY_ZERO,NO_AUTO_CREATE_USER,NO_ENGINE_SUBSTITUTION which breaks the system