57141[TASK] Align impexp functional export tests between db engines
Commit message
Review
-
Code review CR +2
- Wouter Wolters +2
- Anja Leichsenring +1
-
Verified V +2
- Wouter Wolters +2
- Anja Leichsenring +1
Issues 1
Files 33
- typo3/sysext/core/Tests/Functional/Fixtures/Extensions/irre_tutorial/ext_tables.sql+4 −4
- typo3/sysext/impexp/Tests/Functional/Export/GroupFileAndFileReferenceItemInFlexFormTest.php+1 −1
- typo3/sysext/impexp/Tests/Functional/Export/GroupFileAndFileReferenceItemTest.php+2 −2
- typo3/sysext/impexp/Tests/Functional/Export/IrreTutorialRecordsTest.php+1 −1
- typo3/sysext/impexp/Tests/Functional/Export/PagesAndTtContentTest.php+1 −1
- typo3/sysext/impexp/Tests/Functional/Export/PagesAndTtContentWithImagesTest.php+3 −3
- typo3/sysext/impexp/Tests/Functional/Fixtures/DatabaseAssertions/importIrreRecords.csv+12 −12
- typo3/sysext/impexp/Tests/Functional/Fixtures/DatabaseImports/irre_tutorial.xml+4 −4
- typo3/sysext/impexp/Tests/Functional/Fixtures/XmlExports/mssql/impexp-group-file-and-file_reference-item-but-images-not-included.xmldeleted+0 −228
- typo3/sysext/impexp/Tests/Functional/Fixtures/XmlExports/mssql/impexp-group-file-and-file_reference-item-in-ff.xmldeleted+0 −689
- typo3/sysext/impexp/Tests/Functional/Fixtures/XmlExports/mssql/impexp-group-file-and-file_reference-item.xmldeleted+0 −481
- typo3/sysext/impexp/Tests/Functional/Fixtures/XmlExports/mssql/pages-and-ttcontent-with-corrupt-image.xmldeleted+0 −593
- typo3/sysext/impexp/Tests/Functional/Fixtures/XmlExports/mssql/pages-and-ttcontent-with-image-but-not-included.xmldeleted+0 −452
- typo3/sysext/impexp/Tests/Functional/Fixtures/XmlExports/mssql/pages-and-ttcontent-with-image.xmldeleted+0 −593
- typo3/sysext/impexp/Tests/Functional/Fixtures/XmlExports/mssql/pages-and-ttcontent.xmldeleted+0 −383
- typo3/sysext/impexp/Tests/Functional/Fixtures/XmlExports/mysql/irre-records.xmldeleted+0 −1839
- typo3/sysext/impexp/Tests/Functional/Fixtures/XmlExports/postgresql/impexp-group-file-and-file_reference-item-but-images-not-included.xmldeleted+0 −228
- typo3/sysext/impexp/Tests/Functional/Fixtures/XmlExports/postgresql/impexp-group-file-and-file_reference-item-in-ff.xmldeleted+0 −689
- typo3/sysext/impexp/Tests/Functional/Fixtures/XmlExports/postgresql/impexp-group-file-and-file_reference-item.xmldeleted+0 −482
- typo3/sysext/impexp/Tests/Functional/Fixtures/XmlExports/postgresql/irre-records.xmldeleted+0 −1839
Show 13 more files
- typo3/sysext/impexp/Tests/Functional/Fixtures/XmlExports/postgresql/pages-and-ttcontent-with-corrupt-image.xmldeleted+0 −594
- typo3/sysext/impexp/Tests/Functional/Fixtures/XmlExports/postgresql/pages-and-ttcontent-with-image-but-not-included.xmldeleted+0 −452
- typo3/sysext/impexp/Tests/Functional/Fixtures/XmlExports/postgresql/pages-and-ttcontent-with-image.xmldeleted+0 −594
- typo3/sysext/impexp/Tests/Functional/Fixtures/XmlExports/postgresql/pages-and-ttcontent.xmldeleted+0 −383
- typo3/sysext/impexp/Tests/Functional/Fixtures/XmlExports/impexp-group-file-and-file_reference-item-but-images-not-included.xmlrenamed+0 −0
- typo3/sysext/impexp/Tests/Functional/Fixtures/XmlExports/impexp-group-file-and-file_reference-item-in-ff.xmlrenamed+0 −0
- typo3/sysext/impexp/Tests/Functional/Fixtures/XmlExports/impexp-group-file-and-file_reference-item.xmlrenamed+0 −0
- typo3/sysext/impexp/Tests/Functional/Fixtures/XmlExports/irre-records.xmlrenamed+355 −355
- typo3/sysext/impexp/Tests/Functional/Fixtures/XmlExports/pages-and-ttcontent-with-corrupt-image.xmlrenamed+0 −0
- typo3/sysext/impexp/Tests/Functional/Fixtures/XmlExports/pages-and-ttcontent-with-image-but-not-included.xmlrenamed+0 −0
- typo3/sysext/impexp/Tests/Functional/Fixtures/XmlExports/pages-and-ttcontent-with-image.xmlrenamed+0 −0
- typo3/sysext/impexp/Tests/Functional/Fixtures/XmlExports/pages-and-ttcontent.xmlrenamed+0 −0
- typo3/sysext/impexp/Tests/Functional/AbstractImportExportTestCase.php+1 −13
Review log 1521
-
Christian Kuhn uploaded patch set 1 06/07/18, 17:38
-
TYPO3com voted on patch set 1 V +1 06/07/18, 17:45 Completed build in 07m 07s on Thu, 7 Jun, 07:45 PM Test Summary: 31235 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-24127
-
Christian Kuhn uploaded patch set 2 06/07/18, 17:46
-
Christian Kuhn voted on patch set 2 CR -2 06/07/18, 17:47
-
TYPO3com voted on patch set 2 V +1 06/07/18, 17:55 Completed build in 08m 17s on Thu, 7 Jun, 07:55 PM Test Summary: 31235 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-24128
-
Christian Kuhn uploaded patch set 3 06/07/18, 18:05
-
TYPO3com voted on patch set 3 V -1 06/07/18, 18:11 Completed build in 06m 27s on Thu, 7 Jun, 08:11 PM Test Summary: 4 of 31482 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-24130
-
Christian Kuhn uploaded patch set 4 06/07/18, 18:16
-
TYPO3com voted on patch set 4 V -1 06/07/18, 18:24 Completed build in 07m 39s on Thu, 7 Jun, 08:24 PM Test Summary: 1 of 31483 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-24132
-
Christian Kuhn updated the commit message in patch set 5 06/07/18, 18:34
-
Christian Kuhn voted on patch set 5 CR 0 06/07/18, 18:34
-
Wouter Wolters voted on patch set 5 CR +1 06/07/18, 18:38
-
Anja Leichsenring updated the commit message in patch set 6 06/07/18, 18:38
-
TYPO3com voted on patch set 5 V +1 06/07/18, 18:41 Completed build in 07m 18s on Thu, 7 Jun, 08:41 PM Test Summary: 31235 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-24134
-
Anja Leichsenring voted on patch set 6 V +1 CR +1 06/07/18, 18:41
-
Wouter Wolters voted on patch set 6 CR +1 06/07/18, 18:42
-
Wouter Wolters voted on patch set 6 V +2 CR +2 06/07/18, 18:43
-
Wouter Wolters merged patch set 7 06/07/18, 18:43
-
TYPO3com voted on patch set 6 V +1 06/07/18, 18:45 Completed build in 07m 12s on Thu, 7 Jun, 08:45 PM Test Summary: 31235 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-24135
-
Tymoteusz Motylewski commented on patch set 7 06/21/18, 09:18
post -1. The text column doesn't support default values. This break tests on my machine SQL Error for table "tx_irretutorial_1nff_price": An exception occurred while executing 'INSERT INTO `tx_irretutorial_1nff_price`Field 'price' doesn't have a default value I have no idea yet why it does work on bamboo. As a workaround we can change the coulumn to varchar or remove not null. -
Tymoteusz Motylewski commented on patch set 7 06/21/18, 10:39
The issue is that tests are executed on mysql with sql mode set to: sql_mode NO_AUTO_CREATE_USER,NO_ENGINE_SUBSTITUTION while by default mysql 5.7 has: ONLY_FULL_GROUP_BY,STRICT_TRANS_TABLES,NO_ZERO_IN_DATE,NO_ZERO_DATE,ERROR_FOR_DIVISION_BY_ZERO,NO_AUTO_CREATE_USER,NO_ENGINE_SUBSTITUTION which breaks the system