Review main Merged

57143[TASK] Modernize category collection functional tests

Christian Kuhn CR +2 V +2 Hard +79 −203 updated 06/07/18, 21:38

Commit message

Use a dummy extension and .csv imports from the
functional test framework instead of creating
tables and records on the fly.

Review

  • Code review CR +2
    • Wouter Wolters +2
    • Christian Kuhn +1
  • Verified V +2
    • Wouter Wolters +2
    • Christian Kuhn +1
    • TYPO3com +1 CI

Issues 1

Files 5

Review log 913

  1. Christian Kuhn uploaded patch set 1 06/07/18, 21:18

  2. Christian Kuhn uploaded patch set 2 06/07/18, 21:20

  3. Christian Kuhn uploaded patch set 3 06/07/18, 21:24

  4. Christian Kuhn commented on patch set 3 06/07/18, 21:26

    will merge this if it goes green on bamboo since effectively only test setup/teardown related code is.
  5. TYPO3com voted on patch set 1 V -1 06/07/18, 21:26 Completed build in 08m 06s on Thu, 7 Jun, 11:26 PM Test Summary: 31235 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-24143

  6. Christian Kuhn commented on patch set 3 06/07/18, 21:26

    touched
  7. TYPO3com voted on patch set 2 V -1 06/07/18, 21:28 Completed build in 07m 48s on Thu, 7 Jun, 11:28 PM Test Summary: 31235 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-24144

  8. Christian Kuhn uploaded patch set 4 06/07/18, 21:30

  9. TYPO3com voted on patch set 3 V +1 06/07/18, 21:31 Completed build in 07m 31s on Thu, 7 Jun, 11:31 PM Test Summary: 31235 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-24145

  10. TYPO3com voted on patch set 4 V +1 06/07/18, 21:37 Completed build in 07m 02s on Thu, 7 Jun, 11:37 PM Test Summary: 31235 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-24146

  11. Christian Kuhn voted on patch set 4 V +1 CR +1 06/07/18, 21:38

  12. Wouter Wolters voted on patch set 4 V +2 CR +2 06/07/18, 21:38

  13. Wouter Wolters merged patch set 5 06/07/18, 21:38