Review main Merged

57145[BUGFIX] Make styleguide a require-dev dependency

Christian Kuhn CR +2 V +2 Normal +52 −52 updated 06/08/18, 00:24

Commit message

typo3/cms-styleguide has accidently been made a
require instead of a require-dev dependency
in composer.json

composer require --dev typo3/cms-styleguide ^9.1

Review

  • Code review CR +2
    • Christian Kuhn +2
  • Verified V +2
    • Christian Kuhn +2
    • TYPO3com +1 CI

Issues 2

Files 3

Review log 46

  1. Christian Kuhn uploaded patch set 1 06/08/18, 00:10

  2. Christian Kuhn uploaded patch set 2 06/08/18, 00:16

  3. TYPO3com voted on patch set 1 V -1 06/08/18, 00:17 Completed build in 07m 18s on Fri, 8 Jun, 02:17 AM Test Summary: 31235 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-24152

  4. TYPO3com voted on patch set 2 V +1 06/08/18, 00:24 Completed build in 07m 08s on Fri, 8 Jun, 02:24 AM Test Summary: 31235 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-24153

  5. Christian Kuhn voted on patch set 2 V +2 CR +2 06/08/18, 00:24

  6. Christian Kuhn merged patch set 3 06/08/18, 00:24