Review main Merged

57146[TASK] Store only valid icon markup into local storage

Frank Nägler CR +2 V +2 Easy +4 −2 updated 06/09/18, 15:22

Commit message

This patch prevent putting invalid data into localStorage in the rare
case that the AJAX call does not provide icon markup.

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Benni Mack +1
  • Verified V +2
    • Christian Kuhn +2
    • Andreas Kienast +1
    • Benni Mack +1
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 67

  1. Frank Nägler uploaded patch set 1 06/08/18, 08:03

  2. TYPO3com voted on patch set 1 V +1 06/08/18, 08:10 Completed build in 07m 12s on Fri, 8 Jun, 10:10 AM Test Summary: 31289 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-24161

  3. Andreas Kienast commented on patch set 1 V +1 06/08/18, 09:08

    I get the intention of that change, but I think this must be solved differently. In fact, the issue popped up because the session timed out and JSON was stored in localStorage, instead of icon markup. I think the "real" issue is that the JSON delivered by the session foo must come with a 401 header, which triggers the "error" handler in jQuery.
  4. Frank Nägler commented on patch set 1 06/08/18, 12:30

    nope, the JSON was a side effect of another patch. I think the check for expected markup is ok, but if you have another idea... tell me :)
  5. Benni Mack voted on patch set 1 V +1 CR +1 06/09/18, 15:17

  6. Christian Kuhn voted on patch set 1 V +2 CR +2 06/09/18, 15:22

  7. Christian Kuhn merged patch set 2 06/09/18, 15:22