57148[TASK] Move new SEO fields to separate system extension
Commit message
Review
-
Code review CR +2
- Susi Moog +2
- Benni Mack +1
-
Verified V +2
- Susi Moog +2
- Benni Mack +1
- TYPO3com +1 CI
Issues 1
Files 28
- typo3/sysext/core/Configuration/TCA/pages.php+1 −163
- typo3/sysext/core/Documentation/Changelog/master/Feature-84798-AddSEOFieldsToPagesTCA.rst+4 −3
- typo3/sysext/core/Documentation/Changelog/master/Feature-85147-RenderSEOMetaTagsInFrontend.rst+5 −4
- typo3/sysext/core/Tests/Functional/DataHandling/IRRE/ForeignField/Modify/DataSet/localizeNCopyPageWSynchronization.csv+2 −2
- typo3/sysext/core/Tests/Functional/DataHandling/IRRE/ForeignField/Modify/DataSet/localizePageAddMonoglotHotelChildNCopyPageWSynchronization.csv+2 −2
- typo3/sysext/core/Tests/Functional/DataHandling/IRRE/ForeignField/Modify/DataSet/localizePageNAddHotelChildWExclude.csv+1 −1
- typo3/sysext/core/Tests/Functional/DataHandling/IRRE/ForeignField/Modify/DataSet/localizePageNAddHotelChildWSynchronization.csv+1 −1
- typo3/sysext/core/Tests/Functional/DataHandling/IRRE/ForeignField/Modify/DataSet/localizePageNAddMonoglotHotelChildWSynchronization.csv+1 −1
- typo3/sysext/core/Tests/Functional/DataHandling/IRRE/ForeignField/Modify/DataSet/localizePageWithSynchronizationAndCustomLocalizedHotel.csv+1 −1
- typo3/sysext/core/Tests/Functional/DataHandling/IRRE/ForeignField/Modify/DataSet/localizePageWSynchronization.csv+1 −1
- typo3/sysext/core/Tests/Functional/DataHandling/Regular/Modify/DataSet/localizeNCopyPageWSynchronization.csv+2 −2
- typo3/sysext/core/ext_tables.sql+0 −9
- typo3/sysext/frontend/Classes/Controller/TypoScriptFrontendController.php+0 −129
- typo3/sysext/frontend/Classes/Page/PageGenerator.php+7 −1
- typo3/sysext/frontend/Resources/Private/Language/locallang_tca.xlf+0 −51
- typo3/sysext/frontend/Tests/Unit/Page/PageGeneratorTest.php+0 −4
- typo3/sysext/seo/Classes/Generator/MetaTagGenerator.phpnew+160 −0
- typo3/sysext/seo/Configuration/TCA/Overrides/pages.phpnew+179 −0
- typo3/sysext/seo/Resources/Private/Language/locallang_tca.xlfnew+56 −0
- typo3/sysext/seo/Resources/Public/Icons/Extension.pngnewbinary
Review log 2743
Show 1218 earlier messages
-
Richard Haeser uploaded patch set 1 06/08/18, 09:09
-
Richard Haeser wrote 06/08/18, 09:12
Assignee added: Richard Haeser <richard@maxserv.com> -
TYPO3com voted on patch set 1 V -1 06/08/18, 09:18 Completed build in 08m 32s on Fri, 8 Jun, 11:18 AM Test Summary: 24 of 31536 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-24163
-
Mathias Brodala updated the commit message in patch set 2 06/08/18, 09:22
-
Richard Haeser commented on patch set 2 06/08/18, 09:24
> Patch Set 2: Commit message was updated. I wouldn't call this a new feature. It is only a move from code from EXT:core to EXT:seo but thats just me ;-) -
TYPO3com voted on patch set 2 V -1 06/08/18, 09:29 Completed build in 07m 11s on Fri, 8 Jun, 11:29 AM Test Summary: 24 of 31536 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-24165
-
Mathias Brodala commented on patch set 2 06/08/18, 09:36
> > Patch Set 2: Commit message was updated. > > I wouldn't call this a new feature. It is only a move from code > from EXT:core to EXT:seo but thats just me ;-) Technically you are right but to the outside it will look like a new feature. ;-) But I'm fine with a task too if others think this fits better. -
Richard Haeser commented on patch set 2 06/08/18, 09:37
> > > Patch Set 2: Commit message was updated. > > > > I wouldn't call this a new feature. It is only a move from code > > from EXT:core to EXT:seo but thats just me ;-) > > Technically you are right but to the outside it will look like a > new feature. ;-) But I'm fine with a task too if others think this > fits better. Already discussed with Benni. Will change the original feature RST for this. -
Richard Haeser uploaded patch set 3 06/08/18, 12:01
-
TYPO3com voted on patch set 3 V -1 06/08/18, 12:01 Completed build in 07s on Fri, 8 Jun, 02:01 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-24170
-
Richard Haeser uploaded patch set 4 06/08/18, 12:04
-
Christian Kuhn commented on patch set 3 06/08/18, 12:05
note i'm currently fiddling with the bamboo plan. your current pushes will get red until https://review.typo3.org/#/c/57137/ has been merged and your patch rebased on top of it. -
Richard Haeser commented on patch set 4 06/08/18, 12:06
> note i'm currently fiddling with the bamboo plan. your current > pushes will get red until https://review.typo3.org/#/c/57137/ has > been merged and your patch rebased on top of it. No problem, but the latest failure was just my own fault :P -
Richard Haeser rebased onto patch set 5 06/08/18, 12:09
-
TYPO3com voted on patch set 4 V -1 06/08/18, 12:12 Completed build in 07m 54s on Fri, 8 Jun, 02:12 PM Test Summary: 1433 of 32945 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-24171
-
TYPO3com voted on patch set 5 V -1 06/08/18, 12:22 Completed build in 12m 12s on Fri, 8 Jun, 02:22 PM Test Summary: 36 of 32928 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-24173
-
Richard Haeser uploaded patch set 6 06/08/18, 13:21
-
TYPO3com voted on patch set 6 V -1 06/08/18, 13:29 Completed build in 07m 46s on Fri, 8 Jun, 03:29 PM Test Summary: 21 of 32928 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-24174
-
Richard Haeser uploaded patch set 7 06/08/18, 13:31
-
TYPO3com voted on patch set 7 V +1 06/08/18, 13:39 Completed build in 07m 38s on Fri, 8 Jun, 03:39 PM Test Summary: 32677 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-24175
-
Richard Haeser uploaded patch set 8 06/08/18, 15:03
-
TYPO3com voted on patch set 8 V +1 06/08/18, 15:11 Completed build in 07m 23s on Fri, 8 Jun, 05:11 PM Test Summary: 32677 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-24177
-
Susi Moog uploaded patch set 9 06/09/18, 12:53
-
TYPO3com voted on patch set 9 V +1 06/09/18, 13:00 Completed build in 07m 07s on Sat, 9 Jun, 03:00 PM Test Summary: 32692 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-24188
-
Richard Haeser uploaded patch set 10 06/09/18, 13:12
-
TYPO3com voted on patch set 10 V +1 06/09/18, 13:19 Completed build in 07m 17s on Sat, 9 Jun, 03:19 PM Test Summary: 32692 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-24190
-
Richard Haeser uploaded patch set 11 06/09/18, 13:32
-
TYPO3com voted on patch set 11 V +1 06/09/18, 13:39 Completed build in 07m 20s on Sat, 9 Jun, 03:39 PM Test Summary: 32692 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-24192
-
Benni Mack commented on patch set 11 CR -1 06/09/18, 13:54
on it -
Benni Mack uploaded patch set 12 06/09/18, 14:00
-
Benni Mack uploaded patch set 13 06/09/18, 14:04
-
Benni Mack uploaded patch set 14 06/09/18, 14:05
-
Richard Haeser voted on patch set 14 V +1 CR +1 06/09/18, 14:08
-
TYPO3com voted on patch set 12 V -1 06/09/18, 14:10 Completed build in 09m 01s on Sat, 9 Jun, 04:10 PM Test Summary: 32692 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-24196
-
Susi Moog commented on patch set 15 06/09/18, 14:12
Published edit on patch set 14. -
TYPO3com voted on patch set 13 V -1 06/09/18, 14:12 Completed build in 08m 34s on Sat, 9 Jun, 04:12 PM Test Summary: 32692 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-24197
-
TYPO3com voted on patch set 14 V -1 06/09/18, 14:15 Completed build in 09m 40s on Sat, 9 Jun, 04:15 PM Test Summary: 32692 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-24198
-
TYPO3com voted on patch set 15 V -1 06/09/18, 14:19 Completed build in 07m 28s on Sat, 9 Jun, 04:19 PM Test Summary: 32692 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-24199
-
Benni Mack uploaded patch set 16 06/09/18, 14:26
-
TYPO3com voted on patch set 16 V +1 06/09/18, 14:35 Completed build in 09m 04s on Sat, 9 Jun, 04:35 PM Test Summary: 32692 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-24203
-
Benni Mack voted on patch set 16 V +1 CR +1 06/09/18, 14:35
-
Susi Moog voted on patch set 16 V +2 CR +2 06/09/18, 14:36
-
Susi Moog merged patch set 17 06/09/18, 14:36