Review main Merged

57148[TASK] Move new SEO fields to separate system extension

Richard Haeser CR +2 V +2 Expert +856 −376 updated 06/09/18, 14:36

Commit message

Move the new SEO fields to EXT:seo and prepare the extension for some
basic SEO features.

Review

  • Code review CR +2
    • Susi Moog +2
    • Benni Mack +1
  • Verified V +2
    • Susi Moog +2
    • Benni Mack +1
    • TYPO3com +1 CI

Issues 1

Files 28

Show 8 more files

Review log 2743

Show 1218 earlier messages
  1. Richard Haeser uploaded patch set 1 06/08/18, 09:09

  2. Richard Haeser wrote 06/08/18, 09:12

    Assignee added: Richard Haeser <richard@maxserv.com>
  3. TYPO3com voted on patch set 1 V -1 06/08/18, 09:18 Completed build in 08m 32s on Fri, 8 Jun, 11:18 AM Test Summary: 24 of 31536 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-24163

  4. Mathias Brodala updated the commit message in patch set 2 06/08/18, 09:22

  5. Richard Haeser commented on patch set 2 06/08/18, 09:24

    > Patch Set 2: Commit message was updated. I wouldn't call this a new feature. It is only a move from code from EXT:core to EXT:seo but thats just me ;-)
  6. TYPO3com voted on patch set 2 V -1 06/08/18, 09:29 Completed build in 07m 11s on Fri, 8 Jun, 11:29 AM Test Summary: 24 of 31536 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-24165

  7. Mathias Brodala commented on patch set 2 06/08/18, 09:36

    > > Patch Set 2: Commit message was updated. > > I wouldn't call this a new feature. It is only a move from code > from EXT:core to EXT:seo but thats just me ;-) Technically you are right but to the outside it will look like a new feature. ;-) But I'm fine with a task too if others think this fits better.
  8. Richard Haeser commented on patch set 2 06/08/18, 09:37

    > > > Patch Set 2: Commit message was updated. > > > > I wouldn't call this a new feature. It is only a move from code > > from EXT:core to EXT:seo but thats just me ;-) > > Technically you are right but to the outside it will look like a > new feature. ;-) But I'm fine with a task too if others think this > fits better. Already discussed with Benni. Will change the original feature RST for this.
  9. Richard Haeser uploaded patch set 3 06/08/18, 12:01

  10. TYPO3com voted on patch set 3 V -1 06/08/18, 12:01 Completed build in 07s on Fri, 8 Jun, 02:01 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-24170

  11. Richard Haeser uploaded patch set 4 06/08/18, 12:04

  12. Christian Kuhn commented on patch set 3 06/08/18, 12:05

    note i'm currently fiddling with the bamboo plan. your current pushes will get red until https://review.typo3.org/#/c/57137/ has been merged and your patch rebased on top of it.
  13. Richard Haeser commented on patch set 4 06/08/18, 12:06

    > note i'm currently fiddling with the bamboo plan. your current > pushes will get red until https://review.typo3.org/#/c/57137/ has > been merged and your patch rebased on top of it. No problem, but the latest failure was just my own fault :P
  14. Richard Haeser rebased onto patch set 5 06/08/18, 12:09

  15. TYPO3com voted on patch set 4 V -1 06/08/18, 12:12 Completed build in 07m 54s on Fri, 8 Jun, 02:12 PM Test Summary: 1433 of 32945 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-24171

  16. TYPO3com voted on patch set 5 V -1 06/08/18, 12:22 Completed build in 12m 12s on Fri, 8 Jun, 02:22 PM Test Summary: 36 of 32928 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-24173

  17. Richard Haeser uploaded patch set 6 06/08/18, 13:21

  18. TYPO3com voted on patch set 6 V -1 06/08/18, 13:29 Completed build in 07m 46s on Fri, 8 Jun, 03:29 PM Test Summary: 21 of 32928 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-24174

  1. Richard Haeser uploaded patch set 7 06/08/18, 13:31

  2. TYPO3com voted on patch set 7 V +1 06/08/18, 13:39 Completed build in 07m 38s on Fri, 8 Jun, 03:39 PM Test Summary: 32677 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-24175

  3. Richard Haeser uploaded patch set 8 06/08/18, 15:03

  4. TYPO3com voted on patch set 8 V +1 06/08/18, 15:11 Completed build in 07m 23s on Fri, 8 Jun, 05:11 PM Test Summary: 32677 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-24177

  5. Susi Moog uploaded patch set 9 06/09/18, 12:53

  6. TYPO3com voted on patch set 9 V +1 06/09/18, 13:00 Completed build in 07m 07s on Sat, 9 Jun, 03:00 PM Test Summary: 32692 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-24188

  7. Richard Haeser uploaded patch set 10 06/09/18, 13:12

  8. TYPO3com voted on patch set 10 V +1 06/09/18, 13:19 Completed build in 07m 17s on Sat, 9 Jun, 03:19 PM Test Summary: 32692 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-24190

  9. Richard Haeser uploaded patch set 11 06/09/18, 13:32

  10. TYPO3com voted on patch set 11 V +1 06/09/18, 13:39 Completed build in 07m 20s on Sat, 9 Jun, 03:39 PM Test Summary: 32692 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-24192

  11. Benni Mack commented on patch set 11 CR -1 06/09/18, 13:54

    on it
  12. Benni Mack uploaded patch set 12 06/09/18, 14:00

  13. Benni Mack uploaded patch set 13 06/09/18, 14:04

  14. Benni Mack uploaded patch set 14 06/09/18, 14:05

  15. Richard Haeser voted on patch set 14 V +1 CR +1 06/09/18, 14:08

  16. TYPO3com voted on patch set 12 V -1 06/09/18, 14:10 Completed build in 09m 01s on Sat, 9 Jun, 04:10 PM Test Summary: 32692 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-24196

  17. Susi Moog commented on patch set 15 06/09/18, 14:12

    Published edit on patch set 14.
  18. TYPO3com voted on patch set 13 V -1 06/09/18, 14:12 Completed build in 08m 34s on Sat, 9 Jun, 04:12 PM Test Summary: 32692 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-24197

  19. TYPO3com voted on patch set 14 V -1 06/09/18, 14:15 Completed build in 09m 40s on Sat, 9 Jun, 04:15 PM Test Summary: 32692 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-24198

  20. TYPO3com voted on patch set 15 V -1 06/09/18, 14:19 Completed build in 07m 28s on Sat, 9 Jun, 04:19 PM Test Summary: 32692 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-24199

  21. Benni Mack uploaded patch set 16 06/09/18, 14:26

  22. TYPO3com voted on patch set 16 V +1 06/09/18, 14:35 Completed build in 09m 04s on Sat, 9 Jun, 04:35 PM Test Summary: 32692 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-24203

  23. Benni Mack voted on patch set 16 V +1 CR +1 06/09/18, 14:35

  24. Susi Moog voted on patch set 16 V +2 CR +2 06/09/18, 14:36

  25. Susi Moog merged patch set 17 06/09/18, 14:36