Review main Merged

57149[BUGFIX] l10n_diffsource field can handle empty string and null value

Christian Kuhn CR +2 V +2 Easy +5 −2 updated 06/08/18, 11:30

Commit message

Depending on DB platform, empty LOB fields can be returned
as NULL value (sqlite) or as empty string (mysql, our postgres
setup, mssql).

The patch adapts a minor detail in DataHandler since isset(null)
is false, but isset('') is true, it uses an array_key_exists()
instead for diff check on transOrigDiffSourceField / l10n_diffsource
field to align these two possible different db return values.

Review

  • Code review CR +2
    • Andreas Kienast +2
    • Daniel Siepmann +1
  • Verified V +2
    • Andreas Kienast +2
    • Daniel Siepmann +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 56

  1. Christian Kuhn uploaded patch set 1 06/08/18, 10:52

  2. Daniel Siepmann voted on patch set 1 CR +1 06/08/18, 10:59

  3. TYPO3com voted on patch set 1 V +1 06/08/18, 10:59 Completed build in 07m 10s on Fri, 8 Jun, 12:59 PM Test Summary: 31289 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-24167

  4. Daniel Siepmann voted on patch set 1 V +1 06/08/18, 11:28

  5. Andreas Kienast voted on patch set 1 V +2 CR +2 06/08/18, 11:30

  6. Andreas Kienast merged patch set 2 06/08/18, 11:30