Review main Merged

57150[TASK] Disallow access to .sqlite files

Christian Kuhn CR +2 V +2 Easy +2 −2 updated 06/08/18, 19:53

Commit message

With an upcoming feature to run TYPO3 on sqlite, the
database may end up within Web folder depending on
system setup. It may later come with additional checks to
prevent a direct database download, but it's a good
step to deny web access to .sqlite files via default
.htaccess already.

Review

  • Code review CR +2
    • Jigal van Hemert +2
    • Oliver Klee +1
    • Markus Klein +1
  • Verified V +2
    • Jigal van Hemert +2
    • Markus Klein +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 1214

  1. Christian Kuhn uploaded patch set 1 06/08/18, 13:57

  2. Anja Leichsenring voted on patch set 1 V +1 CR +1 06/08/18, 14:00

  3. Markus Klein commented on patch set 1 V -1 CR -1 06/08/18, 14:01

    _.htaccess:315

    this is wrong. formerly "sql.bak" was blocked, this is not the case anymore
  4. TYPO3com voted on patch set 1 V +1 06/08/18, 14:05 Completed build in 07m 56s on Fri, 8 Jun, 04:05 PM Test Summary: 32677 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-24176

  5. Christian Kuhn commented on patch set 1 06/08/18, 15:12

    grr. regex foo ... thx 4 hint, markus
  6. Markus Klein commented on patch set 2 06/08/18, 15:27

    Published edit on patch set 1.
  7. Markus Klein commented on patch set 2 CR +1 06/08/18, 15:28

    Whenever you have regex issues, feel free to ping me for a review.
  8. Markus Klein voted on patch set 2 V +1 06/08/18, 15:32

  9. TYPO3com voted on patch set 2 V +1 06/08/18, 15:35 Completed build in 07m 14s on Fri, 8 Jun, 05:35 PM Test Summary: 32677 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-24178

  10. Oliver Klee voted on patch set 2 CR +1 06/08/18, 17:13

  11. Jigal van Hemert voted on patch set 2 V +2 CR +2 06/08/18, 18:36

  12. Jigal van Hemert merged patch set 3 06/08/18, 18:36

  13. Benjamin Kott commented on patch set 3 06/08/18, 19:47

    Sorry guys need to post -1 this one. Please keep webserver config for IIS in sync if you do changes to the example apache config especially if its about restrictions.
  14. Markus Klein commented on patch set 3 06/08/18, 19:53

    args.. forgot about it completely! sorry