Review main Merged

57153[TASK] Disallow access to .sqlite files in MS IIS demo config

Christian Kuhn CR +2 V +2 Easy +1 −1 updated 06/11/18, 07:48

Commit message

Review

  • Code review CR +2
    • Benni Mack +2
    • Jigal van Hemert +1
    • Susi Moog +1
  • Verified V +2
    • Benni Mack +2
    • Susi Moog +1
    • TYPO3com +1 CI

Issues 2

Files 1

Review log 78

  1. Christian Kuhn uploaded patch set 1 06/09/18, 10:17

  2. TYPO3com voted on patch set 1 V +1 06/09/18, 10:25 Completed build in 07m 28s on Sat, 9 Jun, 12:25 PM Test Summary: 32677 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-24182

  3. Susi Moog commented on patch set 1 06/09/18, 11:24

    the default settings of iis already disallow access to sqlite files as no mime type is configured - however this adds additional security in case it is configured to be displayed/downloaded.

    _web.config:31

    problem with this rule in general is that it does not match files on root level (it matches example.com/foo/db.sqlite but not example.com/db.sqlite) because of the leading slash.
  4. Christian Kuhn commented on patch set 1 06/09/18, 20:41

    _web.config:31 Reply

    that's probably not too bad, the db will end up in typo3conf/ folder. And that only if stupid people decide to have everything in Web/ folder, which is a terrible idea from security PoV anyway.
  5. Jigal van Hemert commented on patch set 1 CR +1 06/11/18, 05:08

    The scope is only to add the sqlite part after adding it to _.htaccess. As indicated in slack there are more things missing from _web.confing compared to _.htaccess . Without IIS it's rather impossible for me to actually test it. If the rest of the line already works then the addition must also work imo.
  6. Susi Moog commented on patch set 1 V +1 CR +1 06/11/18, 07:45

    I can verify that it works as intended (after adding a mime-mapping, else IIS disallows by default)
  7. Benni Mack voted on patch set 1 V +2 CR +2 06/11/18, 07:48

  8. Benni Mack merged patch set 2 06/11/18, 07:48