Review main Merged

57157[TASK] Clean up MetaTagManager API

Benni Mack CR +2 V +2 Normal +31 −69 updated 06/09/18, 16:16

Commit message

Both the MetaTagManagerRegistry and the MetaTagManager are
singletons via TYPO3's SingletonInterface, thus, there is no
need for having a getInstance() within the API itself,
nor in any abstract / generic base classes.

Review

  • Code review CR +2
    • Oliver Hader +2
    • Anja Leichsenring +1
  • Verified V +2
    • Oliver Hader +2
    • Anja Leichsenring +1
    • TYPO3com +1 CI

Issues 1

Files 8

Review log 1726

Show 1 earlier messages
  1. Benni Mack uploaded patch set 1 06/09/18, 13:42

  1. TYPO3com voted on patch set 1 V +1 06/09/18, 13:50 Completed build in 07m 22s on Sat, 9 Jun, 03:50 PM Test Summary: 32689 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-24193

  2. Benni Mack uploaded patch set 2 06/09/18, 14:37

  3. Benni Mack updated the commit message in patch set 3 06/09/18, 14:41

  4. Benni Mack uploaded patch set 4 06/09/18, 14:42

  5. TYPO3com voted on patch set 4 V -1 06/09/18, 14:44 Completed build in 01m 11s on Sat, 9 Jun, 04:44 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-24207

  6. Benni Mack uploaded patch set 5 06/09/18, 14:44

  7. TYPO3com voted on patch set 2 V -1 06/09/18, 14:45 Completed build in 07m 46s on Sat, 9 Jun, 04:45 PM Test Summary: 2722 of 32937 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-24204

  8. TYPO3com voted on patch set 3 V -1 06/09/18, 14:50 Completed build in 09m 25s on Sat, 9 Jun, 04:50 PM Test Summary: 2722 of 32937 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-24206

  9. TYPO3com voted on patch set 5 V -1 06/09/18, 14:52 Completed build in 07m 48s on Sat, 9 Jun, 04:52 PM Test Summary: 2722 of 32937 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-24208

  10. Richard Haeser voted on patch set 5 CR +1 06/09/18, 14:56

  11. Benni Mack uploaded patch set 6 06/09/18, 14:56

  12. TYPO3com voted on patch set 6 V -1 06/09/18, 15:04 Completed build in 07m 53s on Sat, 9 Jun, 05:04 PM Test Summary: 9 of 32937 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-24210

  13. Benni Mack uploaded patch set 7 06/09/18, 15:16

  14. TYPO3com voted on patch set 7 V +1 06/09/18, 15:26 Completed build in 10m 23s on Sat, 9 Jun, 05:26 PM Test Summary: 32689 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-24215

  15. Oliver Hader commented on patch set 7 06/09/18, 16:01

    MetaTagManagerRegistry.php:42

    Can be removed as well...
  16. Oliver Hader uploaded patch set 8 06/09/18, 16:02

  17. Oliver Hader voted on patch set 8 V +1 CR +1 06/09/18, 16:02

  18. Anja Leichsenring commented on patch set 8 V -1 06/09/18, 16:06

    on it

    GenericMetaTagManager.php:23 Unresolved

    this method is final -> this class is final
  19. Anja Leichsenring uploaded patch set 9 06/09/18, 16:07

  20. Anja Leichsenring voted on patch set 9 V +1 CR +1 06/09/18, 16:08

  21. TYPO3com voted on patch set 8 V +1 06/09/18, 16:11 Completed build in 08m 25s on Sat, 9 Jun, 06:11 PM Test Summary: 32689 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-24220

  22. Oliver Hader voted on patch set 9 V +2 CR +2 06/09/18, 16:12

  23. Oliver Hader commented on patch set 9 06/09/18, 16:12

    Waiting for Bamboo..
  24. TYPO3com voted on patch set 9 V +1 06/09/18, 16:15 Completed build in 07m 11s on Sat, 9 Jun, 06:15 PM Test Summary: 32689 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-24221

  25. Oliver Hader merged patch set 10 06/09/18, 16:16