57157[TASK] Clean up MetaTagManager API
Commit message
Review
-
Code review CR +2
- Oliver Hader +2
- Anja Leichsenring +1
-
Verified V +2
- Oliver Hader +2
- Anja Leichsenring +1
- TYPO3com +1 CI
Issues 1
Files 8
- typo3/sysext/core/Classes/MetaTag/AbstractMetaTagManager.php+0 −11
- typo3/sysext/core/Classes/MetaTag/GenericMetaTagManager.php1+6 −10
- typo3/sysext/core/Classes/MetaTag/MetaTagManagerInterface.php+1 −7
- typo3/sysext/core/Classes/MetaTag/MetaTagManagerRegistry.php1+5 −11
- typo3/sysext/core/Classes/Page/PageRenderer.php+14 −17
- typo3/sysext/core/Tests/Unit/MetaTag/MetaTagManagerRegistryTest.php+1 −9
- typo3/sysext/core/Tests/Unit/Page/PageRendererTest.php+3 −3
- typo3/sysext/core/ext_localconf.php+1 −1
Review log 1726
Show 1 earlier messages
-
Benni Mack uploaded patch set 1 06/09/18, 13:42
-
TYPO3com voted on patch set 1 V +1 06/09/18, 13:50 Completed build in 07m 22s on Sat, 9 Jun, 03:50 PM Test Summary: 32689 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-24193
-
Benni Mack uploaded patch set 2 06/09/18, 14:37
-
Benni Mack updated the commit message in patch set 3 06/09/18, 14:41
-
Benni Mack uploaded patch set 4 06/09/18, 14:42
-
TYPO3com voted on patch set 4 V -1 06/09/18, 14:44 Completed build in 01m 11s on Sat, 9 Jun, 04:44 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-24207
-
Benni Mack uploaded patch set 5 06/09/18, 14:44
-
TYPO3com voted on patch set 2 V -1 06/09/18, 14:45 Completed build in 07m 46s on Sat, 9 Jun, 04:45 PM Test Summary: 2722 of 32937 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-24204
-
TYPO3com voted on patch set 3 V -1 06/09/18, 14:50 Completed build in 09m 25s on Sat, 9 Jun, 04:50 PM Test Summary: 2722 of 32937 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-24206
-
TYPO3com voted on patch set 5 V -1 06/09/18, 14:52 Completed build in 07m 48s on Sat, 9 Jun, 04:52 PM Test Summary: 2722 of 32937 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-24208
-
Richard Haeser voted on patch set 5 CR +1 06/09/18, 14:56
-
Benni Mack uploaded patch set 6 06/09/18, 14:56
-
TYPO3com voted on patch set 6 V -1 06/09/18, 15:04 Completed build in 07m 53s on Sat, 9 Jun, 05:04 PM Test Summary: 9 of 32937 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-24210
-
Benni Mack uploaded patch set 7 06/09/18, 15:16
-
TYPO3com voted on patch set 7 V +1 06/09/18, 15:26 Completed build in 10m 23s on Sat, 9 Jun, 05:26 PM Test Summary: 32689 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-24215
-
Oliver Hader commented on patch set 7 06/09/18, 16:01
-
Oliver Hader uploaded patch set 8 06/09/18, 16:02
-
Oliver Hader voted on patch set 8 V +1 CR +1 06/09/18, 16:02
-
Anja Leichsenring commented on patch set 8 V -1 06/09/18, 16:06
on itGenericMetaTagManager.php:23Unresolvedthis method is final -> this class is final -
Anja Leichsenring uploaded patch set 9 06/09/18, 16:07
-
Anja Leichsenring voted on patch set 9 V +1 CR +1 06/09/18, 16:08
-
TYPO3com voted on patch set 8 V +1 06/09/18, 16:11 Completed build in 08m 25s on Sat, 9 Jun, 06:11 PM Test Summary: 32689 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-24220
-
Oliver Hader voted on patch set 9 V +2 CR +2 06/09/18, 16:12
-
Oliver Hader commented on patch set 9 06/09/18, 16:12
Waiting for Bamboo.. -
TYPO3com voted on patch set 9 V +1 06/09/18, 16:15 Completed build in 07m 11s on Sat, 9 Jun, 06:15 PM Test Summary: 32689 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-24221
-
Oliver Hader merged patch set 10 06/09/18, 16:16
MetaTagManagerRegistry.php:42