Review main Merged

57160[TASK] Store legacy deprecation file in generic log folder

Benni Mack CR +2 V +2 Easy +2 −2 updated 06/09/18, 19:46

Commit message

The deprecation log file that was used prior to v9.0, was previously
stored in typo3conf/deprecation_* which is still used for extensions
still using the old API, is now put into var/log/ where all other
log files reside.

For installations using the environment concept with
"$_ENV['TYPO3_PATH_APP']" - e.g. all installations in composer mode -
the file is now created at that place, for installations having
everything in the public web root, the file is now in
"typo3temp/var/log/deprecation_...log".

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Anja Leichsenring +1
  • Verified V +2
    • Christian Kuhn +2
    • Anja Leichsenring +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 810

  1. Benni Mack uploaded patch set 1 06/09/18, 15:10

  2. Benni Mack updated the commit message in patch set 2 06/09/18, 15:14

  3. TYPO3com voted on patch set 1 V +1 06/09/18, 15:19 Completed build in 08m 57s on Sat, 9 Jun, 05:19 PM Test Summary: 32692 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-24212

  4. TYPO3com voted on patch set 2 V +1 06/09/18, 15:24 Completed build in 09m 55s on Sat, 9 Jun, 05:24 PM Test Summary: 32692 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-24214

  5. Anja Leichsenring voted on patch set 2 V +1 CR +1 06/09/18, 16:00

  6. Christian Kuhn voted on patch set 2 V +2 CR +2 06/09/18, 16:01

  7. Christian Kuhn merged patch set 3 06/09/18, 16:01

  8. Markus Klein commented on patch set 3 06/09/18, 19:40

    wouldn't that at least deserve an important.rst??
  9. Benni Mack commented on patch set 3 06/09/18, 19:45

    It's actually part of the bigger trigger_error() RST file we added back in 9.0, as this part was actually forgotten when all the other places with getVarPath() were changed. I will look the place up where it was documented already, otherwise will come up with sth.
  10. Markus Klein commented on patch set 3 06/09/18, 19:46

    Thanks for info