Review main Merged

57162[TASK] Move MetaTagManagers of OpenGraph and Twitter to EXT:seo

Benni Mack CR +2 V +2 Normal +37 −19 updated 06/09/18, 20:07

Commit message

The new SEO extension handles opengraph and twitter (seo-relevant),
thus do not need to stay in EXT:core, as they are only for sites which
need SEO relevant information to be processed.

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Richard Haeser +1
    • Susi Moog +1
  • Verified V +2
    • Christian Kuhn +2
    • Susi Moog +1
    • TYPO3com +1 CI

Issues 1

Files 10

Review log 67

  1. Benni Mack uploaded patch set 1 06/09/18, 18:04

  2. TYPO3com voted on patch set 1 V +1 06/09/18, 18:15 Completed build in 10m 14s on Sat, 9 Jun, 08:15 PM Test Summary: 32689 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-24234

  3. Richard Haeser voted on patch set 1 CR +1 06/09/18, 18:31

  4. Susi Moog voted on patch set 1 CR +1 06/09/18, 19:30

  5. Susi Moog voted on patch set 1 V +1 06/09/18, 19:36

  6. Christian Kuhn commented on patch set 1 V +2 CR +2 06/09/18, 20:07

    MetaTagManagerRegistryTest.php:23

    that's not optimal that a core test now has a dependency to ext:seo ... could be refactored / splitted ... but not a blocker, i guess.
  7. Christian Kuhn merged patch set 2 06/09/18, 20:07