57162[TASK] Move MetaTagManagers of OpenGraph and Twitter to EXT:seo
Commit message
Review
-
Code review CR +2
- Christian Kuhn +2
- Richard Haeser +1
- Susi Moog +1
-
Verified V +2
- Christian Kuhn +2
- Susi Moog +1
- TYPO3com +1 CI
Issues 1
Files 10
- typo3/sysext/core/Tests/Unit/MetaTag/MetaTagManagerRegistryTest.php1+4 −2
- typo3/sysext/core/ext_localconf.php+0 −8
- typo3/sysext/seo/Classes/MetaTag/MetaTagGenerator.phprenamed+2 −1
- typo3/sysext/seo/Classes/MetaTag/OpenGraphMetaTagManager.phprenamed+3 −1
- typo3/sysext/seo/Classes/MetaTag/TwitterCardMetaTagManager.phprenamed+3 −1
- typo3/sysext/seo/Tests/Unit/MetaTag/OpenGraphMetaTagManagerTest.phprenamed+4 −2
- typo3/sysext/seo/Tests/Unit/MetaTag/TwitterCardMetaTagManagerTest.phprenamed+3 −2
- typo3/sysext/seo/composer.json+5 −0
- typo3/sysext/seo/ext_localconf.php+12 −2
- composer.json+1 −0
Review log 67
-
Benni Mack uploaded patch set 1 06/09/18, 18:04
-
TYPO3com voted on patch set 1 V +1 06/09/18, 18:15 Completed build in 10m 14s on Sat, 9 Jun, 08:15 PM Test Summary: 32689 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-24234
-
Richard Haeser voted on patch set 1 CR +1 06/09/18, 18:31
-
Susi Moog voted on patch set 1 CR +1 06/09/18, 19:30
-
Susi Moog voted on patch set 1 V +1 06/09/18, 19:36
-
Christian Kuhn commented on patch set 1 V +2 CR +2 06/09/18, 20:07
-
Christian Kuhn merged patch set 2 06/09/18, 20:07
MetaTagManagerRegistryTest.php:23