Review main Merged

57163[TASK] Migrate PATH_site usages to Environment API - Part 1

Benni Mack CR +2 V +2 Normal +45 −37 updated 06/14/18, 17:08

Commit message

Use Environment::getPublicPath() and Environment::getProjectPath()
respectively, depending on the use-case instead of PATH_site.

Review

  • Code review CR +2
    • Georg Ringer +2
    • Christian Kuhn +1
  • Verified V +2
    • Georg Ringer +2
    • Christian Kuhn +1
    • TYPO3com +1 CI

Issues 1

Files 11

Review log 811

  1. Benni Mack uploaded patch set 1 06/09/18, 19:05

  2. TYPO3com voted on patch set 1 V +1 06/09/18, 19:19 Completed build in 14m 43s on Sat, 9 Jun, 09:19 PM Test Summary: 32689 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-24242

  3. Benni Mack updated the commit message in patch set 2 06/14/18, 09:59

  4. TYPO3com voted on patch set 2 V +1 06/14/18, 10:07 Completed build in 08m 54s on Thu, 14 Jun, 12:07 PM Test Summary: 32684 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-24432

  5. Christian Kuhn commented on patch set 2 06/14/18, 10:10

    QueryView.php:940

    does $fieldSetup['uploadfolder'] always have a / in front?
  6. Benni Mack commented on patch set 3 06/14/18, 10:11

    Published edit on patch set 2.
  7. Benni Mack commented on patch set 3 06/14/18, 10:11

    you're right.
  8. TYPO3com voted on patch set 3 V +1 06/14/18, 10:19 Completed build in 07m 59s on Thu, 14 Jun, 12:19 PM Test Summary: 32684 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-24434

  9. Christian Kuhn voted on patch set 3 V +1 CR +1 06/14/18, 11:32

  10. Georg Ringer voted on patch set 3 V +2 CR +2 06/14/18, 17:08

  11. Georg Ringer merged patch set 4 06/14/18, 17:08