Review main Merged

57166[BUGFIX] Documentation: use FQCN in Table Garbage Collection Tasks

TYPO3com CR +2 V +2 Easy +2 −2 updated 06/10/18, 10:28

Commit message

The fully qualified class name of class `TableGarbageCollectionTask`
must be used to configure database tables, which should be cleaned up
(inactive or deleted records removed from the system).

This change replaces `tx_scheduler_TableGarbageCollection` with the
correct class name in the documentation:
\TYPO3\CMS\Scheduler\Task\TableGarbageCollectionTask::class

Review

  • Code review CR +2
    • Anja Leichsenring +2
    • Christian Kuhn +1
  • Verified V +2
    • Anja Leichsenring +2
    • Christian Kuhn +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 710

  1. TYPO3com uploaded patch set 1 06/10/18, 09:40

  2. TYPO3com voted on patch set 1 V +1 06/10/18, 09:48 Completed build in 08m 01s on Sun, 10 Jun, 11:48 AM Test Summary: 32698 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-24275

  3. Michael Schams updated the commit message in patch set 2 06/10/18, 10:04

  4. TYPO3com voted on patch set 2 V +1 06/10/18, 10:12 Completed build in 08m 18s on Sun, 10 Jun, 12:12 PM Test Summary: 32698 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-24276

  5. Helmut Hummel commented on patch set 2 06/10/18, 10:16

    that is imho an unnecessary breaking change, which should at least be mitigated by looking up both array keys
  6. Helmut Hummel commented on patch set 2 06/10/18, 10:18

    ah, it already changed in code and this only is about documenting that?
  7. Michael Schams commented on patch set 2 06/10/18, 10:23

    This patch is to correct the documentation. The currently documented approach does not work. One should use the FQCN instead of "tx_scheduler_TableGarbageCollection".
  8. Christian Kuhn voted on patch set 2 V +1 CR +1 06/10/18, 10:25

  9. Anja Leichsenring voted on patch set 2 V +2 CR +2 06/10/18, 10:28

  10. Anja Leichsenring merged patch set 3 06/10/18, 10:28