57167[TASK] Remove static method variables
Commit message
Review
-
Code review CR +2
- Andreas Kienast +2
- Anja Leichsenring +1
-
Verified V +2
- Andreas Kienast +2
- Anja Leichsenring +1
- TYPO3com +1 CI
Issues 1
Files 26
- typo3/sysext/backend/Classes/Form/Utility/FormEngineUtility.php+4 −4
- typo3/sysext/backend/Classes/Tree/View/AbstractTreeView.php1+8 −3
- typo3/sysext/backend/Classes/Utility/BackendUtility.php+15 −15
- typo3/sysext/backend/Tests/Unit/Form/FormDataProvider/TcaSelectItemsTest.php+9 −0
- typo3/sysext/backend/Tests/Unit/Form/InlineStackProcessorTest.php+33 −0
- typo3/sysext/backend/Tests/Unit/Utility/Fixtures/ProcessedValueForGroupWithMultipleAllowedTablesFixture.php+14 −10
- typo3/sysext/backend/Tests/Unit/Utility/Fixtures/ProcessedValueForGroupWithOneAllowedTableFixture.php+14 −10
- typo3/sysext/core/Classes/Authentication/BackendUserAuthentication.php+3 −1
- typo3/sysext/core/Classes/Resource/OnlineMedia/Processing/PreviewProcessing.php1+2 −5
- typo3/sysext/core/Classes/Resource/Processing/LocalImageProcessor.php1+2 −7
- typo3/sysext/core/Classes/Resource/ResourceStorage.php1+5 −8
- typo3/sysext/core/Classes/Utility/GeneralUtility.php+7 −8
- typo3/sysext/core/Classes/Utility/PathUtility.php1+1 −7
- typo3/sysext/core/Tests/Unit/Configuration/FlexForm/FlexFormToolsTest.php+32 −0
- typo3/sysext/core/Tests/Unit/Resource/ResourceStorageTest.php+8 −0
- typo3/sysext/core/Tests/Unit/TypoScript/Parser/TypoScriptParserTest.php+12 −1
- typo3/sysext/core/Tests/Unit/Utility/GeneralUtilityTest.php+41 −2
- typo3/sysext/fluid_styled_content/Classes/ViewHelpers/Link/ClickEnlargeViewHelper.php1+2 −6
- typo3/sysext/form/Classes/Domain/Model/Renderable/AbstractRenderable.php+4 −1
- typo3/sysext/form/Tests/Unit/Hooks/DataStructureIdentifierHookTest.php+9 −0
Show 6 more files
- typo3/sysext/frontend/Classes/Typolink/PageLinkBuilder.php+4 −1
- typo3/sysext/frontend/Classes/Utility/EidUtility.php1+6 −5
- typo3/sysext/indexed_search/Classes/FileContentParser.php1+10 −6
- typo3/sysext/indexed_search/Classes/Indexer.php1+1 −1
- typo3/sysext/lowlevel/Classes/Command/DeletedRecordsCommand.php1+5 −8
- typo3/sysext/workspaces/Classes/Command/WorkspaceVersionRecordsCommand.php1+4 −7
Review log 1115
-
Christian Kuhn uploaded patch set 1 06/10/18, 12:57
-
TYPO3com voted on patch set 1 V -1 06/10/18, 12:57 Completed build in 12s on Sun, 10 Jun, 02:57 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-24279
-
Christian Kuhn uploaded patch set 2 06/10/18, 12:58
-
Christian Kuhn commented on patch set 2 CR -1 06/10/18, 13:01
-
TYPO3com voted on patch set 2 V -1 06/10/18, 13:06 Completed build in 08m 00s on Sun, 10 Jun, 03:06 PM Test Summary: 92 of 32948 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-24280
-
Christian Kuhn commented on patch set 2 06/10/18, 13:17
PreviewProcessing.php:251i'm removing this since the init() method is actually not very expensive, and we've done a similar change some weeks ago at a similar place already, too.LocalImageProcessor.php:162i'm removing this since the init() method is actually not very expensive, and we've done a similar change some weeks ago at a similar place already, too.ResourceStorage.php:2747note $uniqueNamePrefix has always been empty string, so the if below can be removod. the static $maxNumber can be simply made a standard non static var.PathUtility.php:377really, there is zero need to "cache away" a strlen() call ... -> dropped this "cache".ClickEnlargeViewHelper.php:94there is absolutely no reason to make the TypoScriptService a pseudo singleton here. it also has no constructor and no internal state, so just makeInstance() it again if requested.EidUtility.php:105that's ok, even in the eid scope caches are fully initialized.FileContentParser.php:717switching this to a class property is ok since this protected method is always called twice with second call true as argument on the same class instance.Indexer.php:963well, there is just no reason to have this static ..DeletedRecordsCommand.php:253i decided to remove that cache since this CLI does tons of db calls and just calling that loop over TCA multiple times is clearly not a performance issue since the exec time is lost elsewhere anyway.WorkspaceVersionRecordsCommand.php:686i decided to remove that cache since this CLI does tons of db calls and just calling that loop over TCA multiple times is clearly not a performance issue since the exec time is lost elsewhere anyway. -
Christian Kuhn uploaded patch set 3 06/10/18, 13:17
-
Christian Kuhn voted on patch set 3 CR -1 06/10/18, 13:23
-
TYPO3com voted on patch set 3 V -1 06/10/18, 13:25 Completed build in 08m 10s on Sun, 10 Jun, 03:25 PM Test Summary: 92 of 32948 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-24281
-
Christian Kuhn uploaded patch set 4 06/10/18, 13:32
-
TYPO3com voted on patch set 4 V +1 06/10/18, 13:40 Completed build in 08m 47s on Sun, 10 Jun, 03:40 PM Test Summary: 32698 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-24282
-
Anja Leichsenring voted on patch set 4 V +1 CR +1 06/10/18, 14:06
-
Andreas Kienast voted on patch set 4 V +2 CR +1 06/10/18, 14:42
-
Andreas Kienast voted on patch set 4 CR +2 06/10/18, 14:42
-
Andreas Kienast merged patch set 5 06/10/18, 14:42
AbstractTreeView.php:1024