Review main Merged

57168[TASK] Repair failing acceptance test

Anja Leichsenring CR +2 V +2 Easy +6 −6 updated 06/12/18, 17:34

Commit message

The test uses now a method to check on the element that takes the
DOM into consideration, and not the visibility on the interface.

Not the backend changed anything, but the testing methods of
codeception cause this failure. Using the correct testing method
solves the problem.

Review

  • Code review CR +2
    • Stefan Neufeind +2
    • Christian Kuhn +1
  • Verified V +2
    • Stefan Neufeind +2
    • Christian Kuhn +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 58

  1. Anja Leichsenring uploaded patch set 1 06/10/18, 16:17

  2. TYPO3com voted on patch set 1 V +1 06/10/18, 16:25 Completed build in 08m 06s on Sun, 10 Jun, 06:25 PM Test Summary: 32698 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-24286

  3. TYPO3com voted on patch set 1 V -1 06/10/18, 16:36 Completed build in 07m 00s on Sun, 10 Jun, 06:36 PM Test Summary: 1 of 76 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-TL-1926

  4. TYPO3com voted on patch set 1 V +1 06/10/18, 17:02 Completed build in 39m 38s on Sun, 10 Jun, 07:02 PM Test Summary: 75 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-TL-1926

  5. Christian Kuhn commented on patch set 1 V +1 CR +1 06/12/18, 15:18

    the reason we need this change is https://review.typo3.org/56486 - looks ok to adapt the case case like that now.
  6. Stefan Neufeind voted on patch set 1 V +2 CR +2 06/12/18, 17:13

  7. Stefan Neufeind merged patch set 2 06/12/18, 17:13

  8. Christian Kuhn commented on patch set 2 06/12/18, 17:34

    Cherry Picked This patchset was cherry picked to branch TYPO3_8-7 as commit bc479a885b6c182718c60f35c621f7c8013b5406