Review main Merged

57172[BUGFIX] Fix generation of create action URLs in backend user module

Andreas Kienast CR +2 V +2 Easy +18 −4 updated 06/10/18, 20:18

Commit message

The URLs to the create actions for backend users and backend groups were
built in a strange way which required some quirks to be fully functional.

This patch removes the unnecessary `explodeUrl2Array()` call, which also
renders the `rawurlencode()` obsolete.

Review

  • Code review CR +2
    • Riccardo De Contardi +2
    • Benni Mack +1
  • Verified V +2
    • Riccardo De Contardi +2
    • Benni Mack +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 79

  1. Andreas Kienast uploaded patch set 1 06/10/18, 19:09

  2. TYPO3com voted on patch set 1 V +1 06/10/18, 19:21 Completed build in 12m 02s on Sun, 10 Jun, 09:21 PM Test Summary: 32698 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-24302

  3. Riccardo De Contardi commented on patch set 1 V +1 06/10/18, 19:53

  4. Andreas Kienast uploaded patch set 2 06/10/18, 19:59

  5. TYPO3com voted on patch set 2 V +1 06/10/18, 20:07 Completed build in 08m 04s on Sun, 10 Jun, 10:07 PM Test Summary: 32698 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-24306

  6. Benni Mack voted on patch set 2 V +1 CR +1 06/10/18, 20:15

  7. Riccardo De Contardi commented on patch set 2 V +1 06/10/18, 20:16

  8. Riccardo De Contardi voted on patch set 2 V +2 CR +2 06/10/18, 20:18

  9. Riccardo De Contardi merged patch set 3 06/10/18, 20:18