57174[BUGFIX] Fix broken ?? checks by adding required brackets
Commit message
Review
-
Code review CR +2
- Benni Mack +2
- Christian Kuhn +1
-
Verified V +2
- Benni Mack +2
- Christian Kuhn +1
- TYPO3com +1 CI
Issues 2
Files 2
Review log 1316
-
Frank Nägler uploaded patch set 1 06/11/18, 09:12
-
TYPO3com voted on patch set 1 V +1 06/11/18, 09:20 Completed build in 08m 08s on Mon, 11 Jun, 11:20 AM Test Summary: 32695 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-24315
-
Markus Klein commented on patch set 1 V +1 CR +1 06/11/18, 09:32
sigh, what a no-brainer -
Frank Nägler commented on patch set 1 CR -1 06/11/18, 09:35
check a second place -
Markus Klein voted on patch set 1 V 0 CR 0 06/11/18, 09:36
-
Frank Nägler uploaded patch set 2 06/11/18, 09:41
-
Christian Kuhn commented on patch set 2 CR -1 06/11/18, 09:43
shit. that was my fault ... looking for other places now. -
Frank Nägler commented on patch set 2 CR -2 06/11/18, 09:48
blocked, until we found no more issues -
TYPO3com voted on patch set 2 V +1 06/11/18, 09:50 Completed build in 08m 44s on Mon, 11 Jun, 11:50 AM Test Summary: 32695 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-24316
-
Frank Nägler uploaded patch set 3 06/11/18, 09:52
-
TYPO3com voted on patch set 3 V +1 06/11/18, 10:00 Completed build in 08m 33s on Mon, 11 Jun, 12:00 PM Test Summary: 32695 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-24318
-
Christian Kuhn voted on patch set 3 V +1 CR +1 06/11/18, 10:14
-
Frank Nägler voted on patch set 2 CR 0 06/11/18, 10:15
-
Frank Nägler voted on patch set 3 CR 0 06/11/18, 10:15
-
Benni Mack voted on patch set 3 V +2 CR +2 06/11/18, 10:23
-
Frank Nägler merged patch set 4 06/11/18, 10:23