Review main Merged

57175[TASK] Update @types definitions

Frank Nägler CR +2 V +2 Easy +6 −6 updated 06/12/18, 13:58

Commit message

yarn upgrade @types/bootstrap@3.3.39
yarn upgrade @types/jasmine@2.8.8

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Wouter Wolters +1
    • Benni Mack +1
  • Verified V +2
    • Christian Kuhn +2
    • Benni Mack +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 810

  1. Frank Nägler uploaded patch set 1 06/11/18, 11:57

  2. Frank Nägler commented on patch set 1 CR -2 06/11/18, 11:57

    blocked until next release
  3. Frank Nägler updated the commit message in patch set 2 06/11/18, 12:00

  4. TYPO3com voted on patch set 1 V +1 06/11/18, 12:06 Completed build in 09m 10s on Mon, 11 Jun, 02:06 PM Test Summary: 32695 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-24320

  5. TYPO3com voted on patch set 2 V +1 06/11/18, 12:08 Completed build in 08m 04s on Mon, 11 Jun, 02:08 PM Test Summary: 32695 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-24321

  6. Frank Nägler voted on patch set 2 CR 0 06/12/18, 07:38

  7. Benni Mack voted on patch set 2 V +1 CR +1 06/12/18, 10:49

  8. Wouter Wolters voted on patch set 2 CR +1 06/12/18, 11:24

  9. Christian Kuhn voted on patch set 2 V +2 CR +2 06/12/18, 13:57

  10. Christian Kuhn merged patch set 3 06/12/18, 13:58