Review main Merged

57176[TASK] Update karma components

Frank Nägler CR +2 V +2 Normal +39 −35 updated 06/12/18, 17:46

Commit message

yarn upgrade karma-coverage@1.1.2
yarn upgrade karma-jasmine@1.1.2

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Benni Mack +1
  • Verified V +2
    • Christian Kuhn +2
    • Benni Mack +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 89

  1. Frank Nägler uploaded patch set 1 06/11/18, 12:03

  2. Frank Nägler commented on patch set 1 CR -2 06/11/18, 12:03

    blocked until next release
  3. TYPO3com voted on patch set 1 V +1 06/11/18, 12:13 Completed build in 09m 40s on Mon, 11 Jun, 02:13 PM Test Summary: 32695 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-24322

  4. Frank Nägler voted on patch set 1 CR 0 06/12/18, 07:39

  5. Benni Mack voted on patch set 1 V +1 CR +1 06/12/18, 14:13

  6. Stefan Neufeind commented on patch set 1 06/12/18, 15:22

    Don't we need the changed package.json as well?
  7. Christian Kuhn commented on patch set 1 06/12/18, 17:45

    @stefan: no, there are no package.json changes, the updates are done according to package.json definitions.
  8. Christian Kuhn voted on patch set 1 V +2 CR +2 06/12/18, 17:46

  9. Christian Kuhn merged patch set 2 06/12/18, 17:46