Review main Merged

57182[BUGFIX] Check in images which are marked as changed without changes

Frank Nägler CR +2 V +2 Easy +0 −0 updated 06/12/18, 11:41

Commit message

Looks like a different file encoding of the images results
in marking these icons as changed on OS X.

Review

  • Code review CR +2
    • Benjamin Kott +2
    • Wouter Wolters +1
  • Verified V +2
    • Benjamin Kott +2
    • Wouter Wolters +1

Issues 1

Files 15

Review log 913

  1. Frank Nägler uploaded patch set 1 06/11/18, 13:01

  2. TYPO3com voted on patch set 1 V +1 06/11/18, 13:10 Completed build in 08m 49s on Mon, 11 Jun, 03:10 PM Test Summary: 32695 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-24329

  3. Susi Moog updated the commit message in patch set 2 06/11/18, 14:10

  4. TYPO3com voted on patch set 2 V -1 06/11/18, 14:18 Completed build in 07m 48s on Mon, 11 Jun, 04:18 PM Test Summary: 1 of 32944 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-24333

  5. TYPO3com voted on patch set 2 V +1 06/12/18, 07:26 Completed build in 17h 23m 08s on Tue, 12 Jun, 09:26 AM Test Summary: 32695 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-24333

  6. Benjamin Kott voted on patch set 2 V +1 CR +1 06/12/18, 11:28

  7. Benjamin Kott commented on patch set 2 06/12/18, 11:29

    no changes to these files when recompiling on windows
  8. Benjamin Kott updated the commit message in patch set 3 06/12/18, 11:33

  9. Wouter Wolters voted on patch set 3 V +1 CR +1 06/12/18, 11:33

  10. Benjamin Kott voted on patch set 3 V +2 CR +2 06/12/18, 11:35

  11. Benjamin Kott merged patch set 4 06/12/18, 11:35

  12. Susi Moog voted on patch set 3 V +1 CR +1 06/12/18, 11:35

  13. TYPO3com voted on patch set 3 V +1 06/12/18, 11:41 Completed build in 07m 59s on Tue, 12 Jun, 01:41 PM Test Summary: 32673 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-24359