Review TYPO3_8-7 Merged

57184[BUGFIX] Don’t cut urls in link browser

Frank Nägler CR +2 V +2 Easy +3 −3 updated 06/11/18, 15:05

Commit message

Using the second parameter of TBE_EDITOR.rawurlencode cuts the input to
200 characters for any input value. The parameter is rather useless and
its usage can be simply removed to allow URLs with more than 200
characters.

Review

  • Code review CR +2
    • Susi Moog +2
    • Jörg Bösche +1
    • Andreas Kienast +1
    • Mathias Brodala +1
  • Verified V +2
    • Susi Moog +2
    • Jörg Bösche +1
    • Mathias Brodala +1
    • TYPO3com +1 CI

Issues 1

Files 3

Review log 810

  1. Frank Nägler uploaded patch set 1 06/11/18, 13:35

  2. Andreas Kienast updated the commit message in patch set 2 06/11/18, 13:38

  3. Andreas Kienast voted on patch set 2 CR +1 06/11/18, 13:39

  4. Mathias Brodala commented on patch set 2 V +1 CR +1 06/11/18, 13:39

    The 2nd parameter apparently is a boolean BTW so the 300 here never did what was probably indented. ;-)
  5. Frank Nägler commented on patch set 2 06/11/18, 13:40

    correct ;)
  6. Jörg Bösche voted on patch set 2 V +1 CR +1 06/11/18, 13:42

  7. TYPO3com voted on patch set 1 V +1 06/11/18, 13:45 Completed build in 10m 15s on Mon, 11 Jun, 03:45 PM Test Summary: 58374 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC87-2551

  8. TYPO3com voted on patch set 2 V +1 06/11/18, 13:53 Completed build in 14m 29s on Mon, 11 Jun, 03:53 PM Test Summary: 58374 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC87-2552

  9. Susi Moog voted on patch set 2 V +2 CR +2 06/11/18, 15:05

  10. Susi Moog merged patch set 3 06/11/18, 15:05