Review main Merged

57196[TASK] Remove PHP bug workaround in GIFBUILDER

Benni Mack CR +2 V +2 Easy +2 −11 updated 06/12/18, 11:44

Commit message

TYPO3 has a bound box calculation workaround due to a PHP bug,
which was fixed in PHP 7.0.12 / 7.1, which can now safely be
removed.

Review

  • Code review CR +2
    • Wouter Wolters +2
    • Mathias Schreiber +1
    • Markus Klein +1
  • Verified V +2
    • Wouter Wolters +2
    • Mathias Schreiber +1
    • Markus Klein +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 1012

  1. Benni Mack uploaded patch set 1 06/12/18, 08:29

  2. TYPO3com voted on patch set 1 V +1 06/12/18, 08:37 Completed build in 08m 22s on Tue, 12 Jun, 10:37 AM Test Summary: 32695 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-24346

  3. Benni Mack updated the commit message in patch set 2 06/12/18, 09:13

  4. Markus Klein commented on patch set 2 06/12/18, 09:21

    GraphicalFunctions.php:951

    maybe I'm blind but where do you see that those are resolved? both were closed due to missing feedback
  5. TYPO3com voted on patch set 2 V +1 06/12/18, 09:23 Completed build in 09m 56s on Tue, 12 Jun, 11:23 AM Test Summary: 32673 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-24351

  6. Benni Mack commented on patch set 2 06/12/18, 10:34

    GraphicalFunctions.php:951 Reply

  7. Markus Klein commented on patch set 2 CR +1 06/12/18, 11:25

    GraphicalFunctions.php:951 Reply

    ah thx
  8. Markus Klein voted on patch set 2 V +1 06/12/18, 11:26

  9. Wouter Wolters voted on patch set 2 CR +1 06/12/18, 11:31

  10. Mathias Schreiber voted on patch set 2 V +1 CR +1 06/12/18, 11:39

  11. Wouter Wolters voted on patch set 2 V +2 CR +2 06/12/18, 11:44

  12. Wouter Wolters merged patch set 3 06/12/18, 11:44