Review main Merged

57197[TASK] Remove mis-usage of TemplateService->fileHash

Benni Mack CR +2 V +2 Easy +17 −29 updated 06/12/18, 13:56

Commit message

The fileHash property acts as an internal cache for
TemplateService->getFileName() and was misued since TYPO3 6.0 for
FAL-related information of processed images.

As this is a purely runtime-based cache (and internal), the usages here
are dropped.

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Markus Klein +1
    • Wouter Wolters +1
  • Verified V +2
    • Christian Kuhn +2
    • Markus Klein +1
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 68

  1. Benni Mack uploaded patch set 1 06/12/18, 09:10

  2. TYPO3com voted on patch set 1 V +1 06/12/18, 09:19 Completed build in 09m 34s on Tue, 12 Jun, 11:19 AM Test Summary: 32673 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-24349

  3. Stephan Großberndt updated the commit message in patch set 2 06/12/18, 10:38

  4. TYPO3com voted on patch set 2 V +1 06/12/18, 10:46 Completed build in 08m 03s on Tue, 12 Jun, 12:46 PM Test Summary: 32673 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-24355

  5. Markus Klein voted on patch set 2 V +1 CR +1 06/12/18, 11:21

  6. Wouter Wolters voted on patch set 2 CR +1 06/12/18, 11:25

  7. Christian Kuhn voted on patch set 2 V +2 CR +2 06/12/18, 13:56

  8. Christian Kuhn merged patch set 3 06/12/18, 13:56