Review main Merged

57198[FEATURE] Add infix option for filenames used by FileWriter

Markus Klein CR +2 V +2 Easy +49 −1 updated 07/18/18, 20:36

Commit message

Review

  • Code review CR +2
    • Frank Nägler +2
    • Jürgen Venne +1
  • Verified V +2
    • Frank Nägler +2
    • Jürgen Venne +1
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 2430

Show 35 earlier messages
  1. Markus Klein uploaded patch set 1 06/12/18, 09:45

  2. TYPO3com voted on patch set 1 V +1 06/12/18, 09:54 Completed build in 07m 59s on Tue, 12 Jun, 11:54 AM Test Summary: 32673 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-24353

  3. Helmut Hummel voted on patch set 1 V +1 CR +1 06/13/18, 09:03

  4. Markus Klein uploaded patch set 2 06/22/18, 12:38

  5. TYPO3com voted on patch set 2 V +1 06/22/18, 12:46 Completed build in 08m 16s on Fri, 22 Jun, 02:46 PM Test Summary: 32702 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-24606

  1. Stefan Neufeind commented on patch set 2 06/22/18, 15:49

    Infix? Or possibly better Prefix? I haven't heard Infix before and it's prepended to the filename, so prefix (more common) sounds logical to me.
  2. Susi Moog commented on patch set 2 06/22/18, 21:13

    I'd also prefer Prefix as Infix is something different language wise - and all these words (prefix, suffix, postfix, infix and adfix) usually target words not "variables" - I guess you are using infix as you are not overwriting the file path - nevertheless it's technically a filename prefix.
  3. Markus Klein commented on patch set 2 06/22/18, 21:19

    Nope it is not a prefix! look at the resulting name please.
  4. Markus Klein commented on patch set 2 06/22/18, 21:20

    it is technically added in the middle of the filename, therefore this is an infix.
  5. Susi Moog commented on patch set 2 06/22/18, 21:28

    that's what I meant with targeted at words not at variables. the result is typo3_[prefixforhashthingy]hashthingy which is a prefix not an infix - except if you (and I'm guessing you do) take the infix out of its original word-related context and relate it to complete variable names. But honestly, I don't really care how the setting is named, as long as it's sensibly documented, so what's missing here from my side: config example and resulting name in rst (show the use case ;))
  6. Alexander Stehlik commented on patch set 2 CR -1 06/22/18, 21:35

    The current solution is not very readable IMO. My suggestion: split the path and the template in 2 different variables ($defaultLogDirectory and $defaultLogFileNameTemplate) and make the $defaultLogFileNameTemplate configurable. I do not see the benefit for the infix construct.
  7. Markus Klein commented on patch set 2 06/24/18, 19:17

    > that's what I meant with targeted at words not at variables I don't understand what you mean with this sentence. The target is simply the final log file name, nothing else. I don't really care in how many variables we split this ;-) @Stehlik: This implementation is a try to make the change non-breaking and as backwardscompatible in the file naming as possible.
  8. Markus Klein commented on patch set 2 06/24/18, 19:17

    The whole naming "magic" is not what I would call optimal, but IMO it's the wrong time to change this substantially now.
  9. Josef Glatz commented on patch set 2 06/24/18, 22:34

    Feature-85236-AddedInfixOptionToDefaultLogFileNamesForFileWriter.rst:20

    Please can you add also a code example snippet?
  10. Markus Klein uploaded patch set 3 06/25/18, 12:19

  11. TYPO3com voted on patch set 3 V +1 06/25/18, 12:28 Completed build in 08m 42s on Mon, 25 Jun, 02:28 PM Test Summary: 32729 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-24838

  12. Markus Klein commented on patch set 4 06/25/18, 13:53

    Published edit on patch set 3.
  13. TYPO3com voted on patch set 4 V -1 06/25/18, 14:01 Completed build in 08m 11s on Mon, 25 Jun, 04:01 PM Test Summary: 1 of 32978 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-24843

  14. TYPO3com voted on patch set 4 V +1 06/25/18, 18:04 Completed build in 4h 19m 30s on Mon, 25 Jun, 08:04 PM Test Summary: 32729 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-24843

  15. Josef Glatz wrote 06/26/18, 19:11

    Removed reviewer Josef Glatz.
  16. Benni Mack commented on patch set 4 07/03/18, 09:54

    How about we make FileWriter compatible, so that if the path is relative, that the default log folder is used instead?
  17. Markus Klein commented on patch set 4 07/04/18, 13:34

    This would be breaking Benni, because you can use relative paths now which are relative to index.php!
  18. Jürgen Venne commented on patch set 4 V -1 CR -1 07/06/18, 11:13

    The variable is named LogFileInfix, the documentation says 'infix'. So the infix is not used by the logger when it is set by the 'infix' key. So either rename the variable or the configuration key to match each other.
  19. Markus Klein commented on patch set 5 07/09/18, 06:22

    Published edit on patch set 4.
  20. TYPO3com voted on patch set 5 V +1 07/09/18, 06:29 Completed build in 07m 45s on Mon, 9 Jul, 08:29 AM Test Summary: 32883 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-25229

  21. Jürgen Venne voted on patch set 5 V +1 CR +1 07/09/18, 07:56

  22. Benni Mack commented on patch set 5 07/09/18, 10:35

    do we need this feature at all, if we implement channels anyway? https://review.typo3.org/#/c/48174/
  23. Markus Klein commented on patch set 5 07/09/18, 12:50

    The patch was there first as a prerequesite for a sane solution for deprecations. I don't care too much how we solve it, but we need to solve deprecations.
  24. Frank Nägler voted on patch set 5 V +2 CR +2 07/18/18, 20:36

  25. Frank Nägler merged patch set 6 07/18/18, 20:36