Review main Merged

57202[TASK] Use current request object in Maintenance middleware

Benni Mack CR +2 V +2 Easy +1 −1 updated 06/12/18, 14:01

Commit message

The property `$GLOBALS['TYPO3_REQUEST']` is not needed when inside
a middleware, as the current PSR-7 request object is already available.

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Wouter Wolters +1
    • Tymoteusz Motylewski +1
    • Mathias Brodala +1
  • Verified V +2
    • Christian Kuhn +2
    • Tymoteusz Motylewski +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 67

  1. Benni Mack uploaded patch set 1 06/12/18, 12:27

  2. Mathias Brodala voted on patch set 1 CR +1 06/12/18, 12:28

  3. TYPO3com voted on patch set 1 V +1 06/12/18, 12:35 Completed build in 08m 33s on Tue, 12 Jun, 02:35 PM Test Summary: 32673 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-24363

  4. Wouter Wolters voted on patch set 1 CR +1 06/12/18, 12:51

  5. Tymoteusz Motylewski voted on patch set 1 V +1 CR +1 06/12/18, 13:10

  6. Christian Kuhn voted on patch set 1 V +2 CR +2 06/12/18, 14:01

  7. Christian Kuhn merged patch set 2 06/12/18, 14:01