Review main Abandoned

57203[BUGFIX] Avoid infinite loop when deleting a file

TYPO3com CR 0 V 0 Easy +3 −1 updated 06/12/18, 20:03

Commit message

This patch now uses two different loop conditions, the current one and
additionally the old one before https://review.typo3.org/57105.

Review

  • Code review CR 0
  • Verified V 0

Issues 2

Files 1

Review log 913

  1. TYPO3com uploaded patch set 1 06/12/18, 12:30

  2. TYPO3com voted on patch set 1 V +1 06/12/18, 12:39 Completed build in 08m 20s on Tue, 12 Jun, 02:39 PM Test Summary: 32673 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-24364

  3. Simon Gilli uploaded patch set 2 06/12/18, 15:13

  4. Simon Gilli commented on patch set 2 CR +1 06/12/18, 15:20

    To not introduce another regression I think it would be best to use the old and the new condition. What do you think?
  5. Simon Gilli wrote 06/12/18, 15:20

    Removed Code-Review+1 by Simon Gilli <typo3@gilbertsoft.org>
  6. TYPO3com voted on patch set 2 V +1 06/12/18, 15:22 Completed build in 08m 14s on Tue, 12 Jun, 05:22 PM Test Summary: 32673 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-24372

  7. Simon Gilli updated the commit message in patch set 3 06/12/18, 15:40

  8. TYPO3com voted on patch set 3 V +1 06/12/18, 15:48 Completed build in 08m 01s on Tue, 12 Jun, 05:48 PM Test Summary: 32673 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-24378

  9. Nicole Hummel commented on patch set 3 CR -1 06/12/18, 16:50

    @Simon: Would you mind to debug what getParentFolder()->getIdentifier() returns for the upper folder? I think this is more an extension bug than a core issue
  10. Simon Gilli commented on patch set 3 06/12/18, 17:24

    > Patch Set 3: Code-Review-1 > > @Simon: Would you mind to debug what getParentFolder()->getIdentifier() returns for the upper folder? I think this is more an extension bug than a core issue Yes, I think too. I don't have the AWS driver in use, I'll talk to Daniel... I'm currently comparing the code of the local driver and https://github.com/andersundsehr/aus_driver_amazon_s3/blob/master/Classes/Driver/AmazonS3Driver.php
  11. Simon Gilli commented on patch set 3 CR -1 06/12/18, 19:13

    > Patch Set 3: > > > Patch Set 3: Code-Review-1 > > > > @Simon: Would you mind to debug what getParentFolder()->getIdentifier() returns for the upper folder? I think this is more an extension bug than a core issue > > Yes, I think too. I don't have the AWS driver in use, I'll talk to Daniel... I'm currently comparing the code of the local driver and https://github.com/andersundsehr/aus_driver_amazon_s3/blob/master/Classes/Driver/AmazonS3Driver.php @Nicole, finally it's a bug in the extension. But now seems to work!? Daniel asked to abandon this patch, can you please do this, I don't have the rights to do...
  12. Nicole Hummel commented on patch set 3 06/12/18, 20:02

    After fiddling with some Windows errors, I can confirm that everything with the mentioned extension works as expected. I'll abandon this patch.
  13. Nicole Hummel abandoned the change 06/12/18, 20:03

    Abandoned as requested.