57204[BUGFIX] Close file handle only if unused in FileWriter
Commit message
Review
-
Code review CR +2
- Benni Mack +2
- Christian Kuhn +1
- Oliver Hader +1
-
Verified V +2
- Benni Mack +2
- Christian Kuhn +1
- TYPO3com +1 CI
Issues 1
Files 2
Review log 1320
-
Susi Moog uploaded patch set 1 06/12/18, 14:20
-
TYPO3com voted on patch set 1 V -1 06/12/18, 14:20 Completed build in 06s on Tue, 12 Jun, 04:20 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-24368
-
Susi Moog uploaded patch set 2 06/12/18, 14:25
-
TYPO3com voted on patch set 2 V -1 06/12/18, 14:25 Completed build in 07s on Tue, 12 Jun, 04:25 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-24369
-
Susi Moog uploaded patch set 3 06/12/18, 14:36
-
TYPO3com voted on patch set 3 V -1 06/12/18, 14:36 Completed build in 07s on Tue, 12 Jun, 04:36 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-24370
-
Susi Moog uploaded patch set 4 06/12/18, 14:38
-
Oliver Hader voted on patch set 4 CR +1 06/12/18, 14:42
-
TYPO3com voted on patch set 4 V -1 06/12/18, 14:46 Completed build in 07m 56s on Tue, 12 Jun, 04:46 PM Test Summary: 8 of 32921 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-24371
-
Susi Moog uploaded patch set 5 06/12/18, 15:33
-
TYPO3com voted on patch set 5 V +1 06/12/18, 15:42 Completed build in 08m 19s on Tue, 12 Jun, 05:42 PM Test Summary: 32676 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-24377
-
Susi Moog updated the commit message in patch set 6 06/12/18, 16:45
-
Susi Moog updated the commit message in patch set 7 06/12/18, 16:45
-
TYPO3com voted on patch set 6 V +1 06/12/18, 16:54 Completed build in 08m 53s on Tue, 12 Jun, 06:54 PM Test Summary: 32676 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-24379
-
TYPO3com voted on patch set 7 V +1 06/12/18, 16:56 Completed build in 10m 35s on Tue, 12 Jun, 06:56 PM Test Summary: 32676 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-24380
-
Christian Kuhn commented on patch set 7 V +1 CR +1 06/12/18, 17:49
nasty ... -
Oliver Hader commented on patch set 7 06/13/18, 07:21
The change looks good for the purpose of using FileWriter. However, I think that we still should pull that handling up one level to Logger/LogManager and reinitialize Writers there. Means: * no sleep/wakeUp for FileWriter, but reinitialization within Logger/LogManager * keep file-handle reference counts in FileWriter -
Oliver Hader commented on patch set 7 CR +1 06/13/18, 08:44
Just discussed with Susi, that pulling wakeUp up one level created more concerns in the current implementation since Logger instances (as well as processors) would need to initialize themselves internally by asking the LogManager. Thus, keeping the patch as is - documenting for user-land code to implement sleep/wakeUp functions in case LoggerAwareTrait is used. -
Benni Mack voted on patch set 7 V +2 CR +2 06/14/18, 04:30
-
Benni Mack merged patch set 8 06/14/18, 04:31