Review TYPO3_8-7 Merged

57206[TASK] Repair failing acceptance test

Christian Kuhn CR +2 V +2 Easy +6 −6 updated 06/12/18, 17:49

Commit message

The test uses now a method to check on the element that takes the
DOM into consideration, and not the visibility on the interface.

Not the backend changed anything, but the testing methods of
codeception cause this failure. Using the correct testing method
solves the problem.

Review

  • Code review CR +2
    • Christian Kuhn +2
  • Verified V +2
    • Christian Kuhn +2
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 34

  1. Christian Kuhn commented on patch set 1 06/12/18, 17:34

    Cherry Picked from branch master.
  2. TYPO3com voted on patch set 1 V +1 06/12/18, 17:48 Completed build in 13m 35s on Tue, 12 Jun, 07:48 PM Test Summary: 58374 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC87-2560

  3. Christian Kuhn voted on patch set 1 V +2 CR +2 06/12/18, 17:49

  4. Christian Kuhn merged patch set 2 06/12/18, 17:49