Review main Merged

57207[BUGFIX] Correctly resolve parent folder in AbstractHierarchicalFilesystemDriver

Nicole Hummel CR +2 V +2 Easy +1 −1 updated 10/28/18, 12:21

Commit message

This patch ensures that
AbstractHierarchicalFilesystemDriver::getParentFolderIdentifierOfIdentifier
always returns a file identifier using forward slashes. Furthermore
it removes double forward slashes for a root folder identifier.

Review

  • Code review CR +2
    • Benni Mack +2
    • Stefan Neufeind +1
    • Andreas Kienast +1
    • Susi Moog +1
  • Verified V +2
    • Benni Mack +2
    • Susi Moog +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 1417

  1. Nicole Hummel uploaded patch set 1 06/13/18, 10:08

  2. TYPO3com voted on patch set 1 V +1 06/13/18, 10:19 Completed build in 10m 59s on Wed, 13 Jun, 12:19 PM Test Summary: 32673 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-24395

  3. Nicole Hummel updated the commit message in patch set 2 06/13/18, 10:19

  4. TYPO3com voted on patch set 2 V +1 06/13/18, 10:27 Completed build in 07m 50s on Wed, 13 Jun, 12:27 PM Test Summary: 32673 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-24396

  5. Nicole Hummel rebased onto patch set 3 06/13/18, 10:49

  6. TYPO3com voted on patch set 3 V +1 06/13/18, 10:57 Completed build in 08m 18s on Wed, 13 Jun, 12:57 PM Test Summary: 32673 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-24397

  7. Benni Mack voted on patch set 3 CR +1 06/14/18, 10:12

  8. Susi Moog voted on patch set 3 CR +1 06/15/18, 13:23

  9. Stefan Neufeind voted on patch set 3 CR +1 06/23/18, 16:34

  10. Oliver Hader commented on patch set 3 07/02/18, 10:41

    Ping
  11. Andreas Kienast voted on patch set 3 CR +1 07/02/18, 12:30

  12. Nicole Hummel commented on patch set 3 07/02/18, 18:15

    @Olly: Anything I can do here or why did you pinged?
  13. Oliver Hader commented on patch set 3 07/02/18, 18:56

    Just wanted to see that rather finished and tested... so it's up to everybody
  14. Susi Moog voted on patch set 3 V +1 10/28/18, 12:20

  15. Benni Mack voted on patch set 3 V +2 CR +2 10/28/18, 12:21

  16. Benni Mack merged patch set 4 10/28/18, 12:21

  17. Benni Mack commented on patch set 4 10/28/18, 12:21

    Cherry Picked This patchset was cherry picked to branch TYPO3_8-7 as commit cf0148689f8bb8d97c8409244568d2b81e3dec89