Review main Merged

57219[TASK] Streamline imports in PHP cache classes

Benni Mack CR +2 V +2 Normal +129 −99 updated 06/15/18, 19:22

Commit message

Most Cache classes haven't been streamlined since their inception,
some unnecessary imports.

The patch organizes the files so their are all imported the same way.

Review

  • Code review CR +2
    • Benni Mack +2
    • Jan Helke +1
  • Verified V +2
    • Benni Mack +2
    • Jan Helke +1
    • TYPO3com +1 CI

Issues 1

Files 13

Review log 810

  1. Benni Mack uploaded patch set 1 06/14/18, 21:08

  2. TYPO3com voted on patch set 1 V +1 06/14/18, 21:16 Completed build in 08m 09s on Thu, 14 Jun, 11:16 PM Test Summary: 32684 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-24442

  3. Christian Kuhn voted on patch set 1 V +1 CR +1 06/15/18, 08:37

  4. Wouter Wolters commented on patch set 1 CR -1 06/15/18, 09:58

    IMHO we agreed to not use half use statements
  5. Christian Kuhn voted on patch set 1 V 0 CR 0 06/15/18, 11:11

  6. Christian Kuhn uploaded patch set 2 06/15/18, 19:01

  7. TYPO3com voted on patch set 2 V +1 06/15/18, 19:10 Completed build in 08m 36s on Fri, 15 Jun, 09:10 PM Test Summary: 32702 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-24507

  8. Jan Helke voted on patch set 2 V +1 CR +1 06/15/18, 19:18

  9. Benni Mack voted on patch set 2 V +2 CR +2 06/15/18, 19:22

  10. Benni Mack merged patch set 3 06/15/18, 19:22