57229[TASK] Use Environment API instead of PATH_site in EXT:backend
Commit message
Review
-
Code review CR +2
- Jan Helke +2
- Christian Kuhn +1
-
Verified V +2
- Jan Helke +2
- Christian Kuhn +1
- TYPO3com +1 CI
Issues 1
Files 6
- typo3/sysext/backend/Classes/Backend/Avatar/Image.php+2 −1
- typo3/sysext/backend/Classes/Controller/LoginController.php+1 −1
- typo3/sysext/backend/Classes/Template/DocumentTemplate.php+1 −1
- typo3/sysext/backend/Classes/Utility/BackendUtility.php+3 −3
- typo3/sysext/backend/Tests/Unit/Form/FormDataProvider/TcaSelectItemsTest.php+9 −8
- typo3/sysext/backend/Tests/Unit/Tree/TreeNodeTest.php1+24 −42
Review log 913
-
Benni Mack uploaded patch set 1 06/15/18, 13:31
-
TYPO3com voted on patch set 1 V -1 06/15/18, 13:32 Completed build in 09s on Fri, 15 Jun, 03:32 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-24476
-
Benni Mack uploaded patch set 2 06/15/18, 13:39
-
Benni Mack commented on patch set 3 06/15/18, 13:40
Published edit on patch set 2. -
TYPO3com voted on patch set 2 V -1 06/15/18, 13:49 Completed build in 09m 57s on Fri, 15 Jun, 03:49 PM Test Summary: 3 of 32951 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-24477
-
TYPO3com voted on patch set 3 V +1 06/15/18, 13:51 Completed build in 11m 27s on Fri, 15 Jun, 03:51 PM Test Summary: 32702 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-24478
-
Christian Kuhn commented on patch set 3 CR -1 06/15/18, 14:07
TreeNodeTest.php:35the entire method could vanish if we use __DIR__ in consuming methods ... -
Christian Kuhn uploaded patch set 4 06/15/18, 14:12
-
TYPO3com voted on patch set 4 V +1 06/15/18, 14:20 Completed build in 08m 48s on Fri, 15 Jun, 04:20 PM Test Summary: 32702 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-24480
-
Christian Kuhn voted on patch set 4 V +1 CR +1 06/15/18, 14:36
-
Jan Helke voted on patch set 4 V +1 CR +1 06/15/18, 15:23
-
Jan Helke voted on patch set 4 V +2 CR +2 06/15/18, 15:26
-
Jan Helke merged patch set 5 06/15/18, 15:26