Review main Merged

57229[TASK] Use Environment API instead of PATH_site in EXT:backend

Benni Mack CR +2 V +2 Normal +40 −56 updated 06/15/18, 15:26

Commit message

Several places of the PATH_site constant in EXT:backend are replaced
by the new Environment API.

Review

  • Code review CR +2
    • Jan Helke +2
    • Christian Kuhn +1
  • Verified V +2
    • Jan Helke +2
    • Christian Kuhn +1
    • TYPO3com +1 CI

Issues 1

Files 6

Review log 913

  1. Benni Mack uploaded patch set 1 06/15/18, 13:31

  2. TYPO3com voted on patch set 1 V -1 06/15/18, 13:32 Completed build in 09s on Fri, 15 Jun, 03:32 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-24476

  3. Benni Mack uploaded patch set 2 06/15/18, 13:39

  4. Benni Mack commented on patch set 3 06/15/18, 13:40

    Published edit on patch set 2.
  5. TYPO3com voted on patch set 2 V -1 06/15/18, 13:49 Completed build in 09m 57s on Fri, 15 Jun, 03:49 PM Test Summary: 3 of 32951 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-24477

  6. TYPO3com voted on patch set 3 V +1 06/15/18, 13:51 Completed build in 11m 27s on Fri, 15 Jun, 03:51 PM Test Summary: 32702 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-24478

  7. Christian Kuhn commented on patch set 3 CR -1 06/15/18, 14:07

    TreeNodeTest.php:35

    the entire method could vanish if we use __DIR__ in consuming methods ...
  8. Christian Kuhn uploaded patch set 4 06/15/18, 14:12

  9. TYPO3com voted on patch set 4 V +1 06/15/18, 14:20 Completed build in 08m 48s on Fri, 15 Jun, 04:20 PM Test Summary: 32702 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-24480

  10. Christian Kuhn voted on patch set 4 V +1 CR +1 06/15/18, 14:36

  11. Jan Helke voted on patch set 4 V +1 CR +1 06/15/18, 15:23

  12. Jan Helke voted on patch set 4 V +2 CR +2 06/15/18, 15:26

  13. Jan Helke merged patch set 5 06/15/18, 15:26