57238[TASK] Use Environment API instead of PATH_site in em
Commit message
Review
-
Code review CR +2
- Benni Mack +2
- Jan Helke +1
-
Verified V +2
- Benni Mack +2
- Jan Helke +1
- TYPO3com +1 CI
Issues 1
Files 7
- typo3/sysext/extensionmanager/Classes/Utility/EmConfUtility.php+5 −2
- typo3/sysext/extensionmanager/Classes/Utility/FileHandlingUtility.php+1 −1
- typo3/sysext/extensionmanager/Classes/Utility/InstallUtility.php+7 −6
- typo3/sysext/extensionmanager/Classes/Utility/ListUtility.php+3 −2
- typo3/sysext/extensionmanager/Classes/ViewHelpers/ReloadSqlDataViewHelper.php1+3 −2
- typo3/sysext/extensionmanager/Tests/Unit/Utility/FileHandlingUtilityTest.php+14 −14
- typo3/sysext/extensionmanager/Tests/Unit/Utility/InstallUtilityTest.php+6 −5
Review log 810
-
Christian Kuhn uploaded patch set 1 06/15/18, 16:08
-
TYPO3com voted on patch set 1 V +1 06/15/18, 16:15 Completed build in 07m 46s on Fri, 15 Jun, 06:15 PM Test Summary: 32702 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-24492
-
Jan Helke voted on patch set 1 V +1 CR +1 06/15/18, 16:20
-
Christian Kuhn commented on patch set 1 CR -1 06/15/18, 18:47
-
Christian Kuhn uploaded patch set 2 06/15/18, 18:49
-
Jan Helke voted on patch set 2 CR +1 06/15/18, 18:51
-
TYPO3com voted on patch set 2 V +1 06/15/18, 18:58 Completed build in 08m 20s on Fri, 15 Jun, 08:58 PM Test Summary: 32702 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-24505
-
Jan Helke voted on patch set 2 V +1 06/15/18, 19:03
-
Benni Mack voted on patch set 2 V +2 CR +2 06/15/18, 19:21
-
Benni Mack merged patch set 3 06/15/18, 19:21
ReloadSqlDataViewHelper.php:52