Review main Merged

57238[TASK] Use Environment API instead of PATH_site in em

Christian Kuhn CR +2 V +2 Normal +39 −32 updated 06/15/18, 19:21

Commit message

Review

  • Code review CR +2
    • Benni Mack +2
    • Jan Helke +1
  • Verified V +2
    • Benni Mack +2
    • Jan Helke +1
    • TYPO3com +1 CI

Issues 1

Files 7

Review log 810

  1. Christian Kuhn uploaded patch set 1 06/15/18, 16:08

  2. TYPO3com voted on patch set 1 V +1 06/15/18, 16:15 Completed build in 07m 46s on Fri, 15 Jun, 06:15 PM Test Summary: 32702 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-24492

  3. Jan Helke voted on patch set 1 V +1 CR +1 06/15/18, 16:20

  4. Christian Kuhn commented on patch set 1 CR -1 06/15/18, 18:47

    ReloadSqlDataViewHelper.php:52

    -1
  5. Christian Kuhn uploaded patch set 2 06/15/18, 18:49

  6. Jan Helke voted on patch set 2 CR +1 06/15/18, 18:51

  7. TYPO3com voted on patch set 2 V +1 06/15/18, 18:58 Completed build in 08m 20s on Fri, 15 Jun, 08:58 PM Test Summary: 32702 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-24505

  8. Jan Helke voted on patch set 2 V +1 06/15/18, 19:03

  9. Benni Mack voted on patch set 2 V +2 CR +2 06/15/18, 19:21

  10. Benni Mack merged patch set 3 06/15/18, 19:21