57243[TASK] Remove NULL initialization and redundant assignments
Commit message
Review
-
Code review CR +2
- Andreas Kienast +2
- Stefan Neufeind +1
- Alexander Schnitzler +1
- Jigal van Hemert +1
-
Verified V +2
- Andreas Kienast +2
- Stefan Neufeind +1
- TYPO3com +1 CI
Issues 1
Files 152
- typo3/sysext/backend/Classes/Backend/ToolbarItems/HelpToolbarItem.php+1 −1
- typo3/sysext/backend/Classes/Backend/ToolbarItems/SystemInformationToolbarItem.php+1 −1
- typo3/sysext/backend/Classes/Controller/Page/TreeController.php+1 −1
- typo3/sysext/backend/Classes/Controller/LoginController.php+1 −1
- typo3/sysext/backend/Classes/Form/FormResultCompiler.php+1 −1
- typo3/sysext/backend/Classes/Module/AbstractFunctionModule.php+2 −2
- typo3/sysext/backend/Classes/Module/BaseScriptClass.php+1 −1
- typo3/sysext/backend/Classes/Search/LiveSearch/LiveSearch.php+1 −1
- typo3/sysext/backend/Classes/Template/DocumentTemplate.php+1 −1
- typo3/sysext/backend/Classes/Tree/View/AbstractTreeView.php+1 −1
- typo3/sysext/backend/Classes/Tree/View/FolderTreeView.php+1 −1
- typo3/sysext/backend/Classes/Tree/AbstractTree.php+2 −2
- typo3/sysext/backend/Classes/Tree/AbstractTreeDataProvider.php+1 −1
- typo3/sysext/backend/Classes/Tree/TreeNode.php+2 −2
- typo3/sysext/backend/Classes/FrontendBackendUserAuthentication.php+2 −2
- typo3/sysext/belog/Classes/Controller/AbstractController.php+1 −1
- typo3/sysext/belog/Classes/Domain/Model/Constraint.php+2 −2
- typo3/sysext/belog/Tests/Unit/Domain/Model/ConstraintTest.php+1 −1
- typo3/sysext/belog/Tests/Unit/Domain/Model/LogEntryTest.php+1 −1
- typo3/sysext/core/Classes/Authentication/AbstractUserAuthentication.php+1 −1
Show 132 more files
- typo3/sysext/core/Classes/Authentication/BackendUserAuthentication.php+1 −1
- typo3/sysext/core/Classes/Configuration/FlexForm/FlexFormTools.php+1 −1
- typo3/sysext/core/Classes/Core/Bootstrap.php+1 −1
- typo3/sysext/core/Classes/Core/SystemEnvironmentBuilder.php+1 −1
- typo3/sysext/core/Classes/Database/ReferenceIndex.php+1 −1
- typo3/sysext/core/Classes/DataHandling/DataHandler.php+2 −2
- typo3/sysext/core/Classes/Encoder/JavaScriptEncoder.php+1 −1
- typo3/sysext/core/Classes/Http/MiddlewareDispatcher.php+1 −1
- typo3/sysext/core/Classes/Http/Uri.php+1 −1
- typo3/sysext/core/Classes/Imaging/Icon.php+1 −1
- typo3/sysext/core/Classes/Log/LogManager.php+1 −1
- typo3/sysext/core/Classes/Mail/Rfc822AddressesParser.php+3 −3
- typo3/sysext/core/Classes/Resource/Driver/LocalDriver.php+1 −1
- typo3/sysext/core/Classes/Resource/Filter/FileExtensionFilter.php+2 −2
- typo3/sysext/core/Classes/Resource/Index/ExtractorRegistry.php+1 −1
- typo3/sysext/core/Classes/Resource/Index/Indexer.php+2 −2
- typo3/sysext/core/Classes/Resource/Rendering/RendererRegistry.php+1 −1
- typo3/sysext/core/Classes/Resource/AbstractFile.php+1 −1
- typo3/sysext/core/Classes/Resource/ResourceFactory.php+1 −1
- typo3/sysext/core/Classes/Resource/ResourceStorage.php+1 −1
- typo3/sysext/core/Classes/Resource/StorageRepository.php+1 −1
- typo3/sysext/core/Classes/Tree/TableConfiguration/AbstractTableConfigurationTreeDataProvider.php+1 −1
- typo3/sysext/core/Classes/TypoScript/ExtendedTemplateService.php+1 −1
- typo3/sysext/core/Classes/Utility/CommandUtility.php+1 −1
- typo3/sysext/core/Classes/Utility/GeneralUtility.php+2 −2
- typo3/sysext/core/Classes/Utility/RootlineUtility.php+1 −1
- typo3/sysext/core/Tests/Functional/Fixtures/Extensions/irre_tutorial/Classes/Domain/Model/Content.php+1 −1
- typo3/sysext/core/Tests/Functional/Fixtures/Extensions/irre_tutorial/Classes/Domain/Model/Hotel.php+1 −1
- typo3/sysext/core/Tests/Functional/Fixtures/Extensions/irre_tutorial/Classes/Domain/Model/Offer.php+1 −1
- typo3/sysext/core/Tests/Unit/Cache/Backend/RedisBackendTest.php+2 −2
- typo3/sysext/core/Tests/Unit/Configuration/TypoScript/ConditionMatching/AbstractConditionMatcherTest.php+1 −1
- typo3/sysext/core/Tests/Unit/Core/SystemEnvironmentBuilderTest.php+1 −1
- typo3/sysext/core/Tests/Unit/Error/DebugExceptionHandlerTest.php+1 −1
- typo3/sysext/core/Tests/Unit/Error/ProductionExceptionHandlerTest.php+1 −1
- typo3/sysext/core/Tests/Unit/Html/HtmlParserTest.php+1 −1
- typo3/sysext/core/Tests/Unit/Html/RteHtmlParserTest.php+1 −1
- typo3/sysext/core/Tests/Unit/Http/MiddlewareDispatcherTest.php+1 −1
- typo3/sysext/core/Tests/Unit/Imaging/IconProvider/BitmapIconProviderTest.php+2 −2
- typo3/sysext/core/Tests/Unit/Imaging/IconProvider/FontawesomeIconProviderTest.php+2 −2
- typo3/sysext/core/Tests/Unit/Imaging/IconProvider/SvgIconProviderTest.php+2 −2
- typo3/sysext/core/Tests/Unit/Imaging/DimensionTest.php+1 −1
- typo3/sysext/core/Tests/Unit/Imaging/GraphicalFunctionsTest.php+1 −1
- typo3/sysext/core/Tests/Unit/Imaging/IconFactoryTest.php+1 −1
- typo3/sysext/core/Tests/Unit/Imaging/IconTest.php+1 −1
- typo3/sysext/core/Tests/Unit/Resource/Driver/AbstractHierarchicalFilesystemDriverTest.php+1 −1
- typo3/sysext/core/Tests/UnitDeprecated/Html/RteHtmlParserTest.php+1 −1
- typo3/sysext/documentation/Classes/Slots/ExtensionManager.php+1 −1
- typo3/sysext/extbase/Classes/Domain/Model/BackendUser.php+2 −2
- typo3/sysext/extbase/Classes/Domain/Model/Category.php+1 −1
- typo3/sysext/extbase/Classes/Domain/Model/FrontendUser.php+2 −2
- typo3/sysext/extbase/Classes/Error/Result.php+1 −1
- typo3/sysext/extbase/Classes/Mvc/Cli/CommandManager.php+2 −2
- typo3/sysext/extbase/Classes/Mvc/Cli/Request.php+2 −2
- typo3/sysext/extbase/Classes/Mvc/Controller/ActionController.php+1 −1
- typo3/sysext/extbase/Classes/Mvc/Controller/Argument.php+5 −5
- typo3/sysext/extbase/Classes/Mvc/Web/Routing/UriBuilder.php+4 −4
- typo3/sysext/extbase/Classes/Mvc/Request.php+5 −5
- typo3/sysext/extbase/Classes/Mvc/Response.php+1 −1
- typo3/sysext/extbase/Classes/Object/Container/Container.php+1 −1
- typo3/sysext/extbase/Classes/Persistence/Generic/Typo3QuerySettings.php+1 −1
- typo3/sysext/extbase/Classes/Persistence/Repository.php+1 −1
- typo3/sysext/extbase/Classes/Property/PropertyMappingConfiguration.php+1 −1
- typo3/sysext/extbase/Classes/Reflection/ClassSchema.php+1 −1
- typo3/sysext/extbase/Classes/Utility/LocalizationUtility.php+1 −1
- typo3/sysext/extbase/Tests/Functional/Fixtures/Extensions/blog_example/Classes/Domain/Model/Blog.php+3 −3
- typo3/sysext/extbase/Tests/Functional/Fixtures/Extensions/blog_example/Classes/Domain/Model/Person.php+2 −2
- typo3/sysext/extbase/Tests/Functional/Fixtures/Extensions/blog_example/Classes/Domain/Model/Post.php+8 −8
- typo3/sysext/extbase/Tests/Unit/Domain/Model/BackendUserGroupTest.php+1 −1
- typo3/sysext/extbase/Tests/Unit/Domain/Model/BackendUserTest.php+1 −1
- typo3/sysext/extbase/Tests/Unit/Domain/Model/CategoryTest.php+1 −1
- typo3/sysext/extbase/Tests/Unit/Domain/Model/FileMountTest.php+1 −1
- typo3/sysext/extbase/Tests/Unit/Domain/Model/FrontendUserGroupTest.php+1 −1
- typo3/sysext/extbase/Tests/Unit/Domain/Model/FrontendUserTest.php+1 −1
- typo3/sysext/extbase/Tests/Unit/Persistence/Generic/QueryFactoryTest.php+2 −2
- typo3/sysext/extensionmanager/Classes/Domain/Model/Extension.php+1 −1
- typo3/sysext/extensionmanager/Classes/Report/ExtensionStatus.php+4 −4
- typo3/sysext/extensionmanager/Classes/Utility/Parser/AbstractExtensionXmlParser.php+17 −17
- typo3/sysext/extensionmanager/Classes/Utility/Parser/AbstractMirrorXmlParser.php+7 −7
- typo3/sysext/extensionmanager/Classes/Utility/Repository/Helper.php+1 −1
- typo3/sysext/extensionmanager/Classes/Utility/ListUtility.php+1 −1
- typo3/sysext/filelist/Classes/Controller/FileListController.php+1 −1
- typo3/sysext/fluid/Classes/View/StandaloneView.php+1 −1
- typo3/sysext/fluid/Classes/ViewHelpers/Form/SelectViewHelper.php+1 −1
- typo3/sysext/fluid/Classes/ViewHelpers/Format/AbstractEncodingViewHelper.php+1 −1
- typo3/sysext/fluid/Classes/ViewHelpers/Widget/Controller/PaginateController.php+2 −2
- typo3/sysext/form/Classes/Domain/Finishers/SaveToDatabaseFinisher.php+1 −1
- typo3/sysext/form/Classes/Domain/Model/FormDefinition.php+1 −1
- typo3/sysext/form/Classes/Domain/Runtime/FormRuntime.php+2 −2
- typo3/sysext/form/Classes/Service/TranslationService.php+2 −2
- typo3/sysext/form/Tests/Unit/ViewHelpers/Form/DatePickerViewHelperTest.php+1 −1
- typo3/sysext/frontend/Classes/ContentObject/Menu/AbstractMenuContentObject.php+4 −4
- typo3/sysext/frontend/Classes/ContentObject/AbstractContentObject.php+1 −1
- typo3/sysext/frontend/Classes/ContentObject/ContentObjectRenderer.php+1 −1
- typo3/sysext/frontend/Classes/ContentObject/FluidTemplateContentObject.php+1 −1
- typo3/sysext/frontend/Classes/Controller/TypoScriptFrontendController.php+4 −4
- typo3/sysext/frontend/Tests/Unit/ContentObject/Menu/AbstractMenuContentObjectTest.php+1 −1
- typo3/sysext/frontend/Tests/Unit/ContentObject/ContentObjectRendererTest.php+4 −4
- typo3/sysext/frontend/Tests/Unit/ContentObject/FilesContentObjectTest.php+2 −2
- typo3/sysext/frontend/Tests/Unit/ContentObject/FluidTemplateContentObjectTest.php+4 −4
- typo3/sysext/frontend/Tests/Unit/Typolink/AbstractTypolinkBuilderTest.php+2 −2
- typo3/sysext/impexp/Classes/Controller/ImportExportController.php+2 −2
- typo3/sysext/impexp/Classes/Export.php+1 −1
- typo3/sysext/impexp/Classes/Import.php+1 −1
- typo3/sysext/impexp/Classes/ImportExport.php+1 −1
- typo3/sysext/indexed_search/Classes/Controller/SearchController.php+1 −1
- typo3/sysext/indexed_search/Classes/Domain/Repository/IndexSearchRepository.php+6 −6
- typo3/sysext/install/Classes/Configuration/AbstractPreset.php+1 −1
- typo3/sysext/install/Classes/FolderStructure/AbstractNode.php+2 −2
- typo3/sysext/install/Classes/FolderStructure/FileNode.php+1 −1
- typo3/sysext/install/Classes/Updates/RowUpdater/RteLinkSyntaxUpdater.php+1 −1
- typo3/sysext/recordlist/Classes/Browser/AbstractElementBrowser.php+1 −1
- typo3/sysext/recordlist/Classes/Controller/ElementBrowserFramesetController.php+1 −1
- typo3/sysext/recordlist/Classes/Controller/RecordListController.php+1 −1
- typo3/sysext/recycler/Classes/Controller/DeletedRecordsController.php+1 −1
- typo3/sysext/recycler/Tests/Unit/Task/CleanerFieldProviderTest.php+1 −1
- typo3/sysext/recycler/Tests/Unit/Task/CleanerTaskTest.php+1 −1
- typo3/sysext/reports/Classes/Task/SystemStatusUpdateTask.php+1 −1
- typo3/sysext/rsaauth/Classes/Backend/BackendFactory.php+1 −1
- typo3/sysext/rsaauth/Classes/Hook/UserSetupHook.php+1 −1
- typo3/sysext/rsaauth/Classes/Storage/StorageFactory.php+1 −1
- typo3/sysext/rsaauth/Classes/RsaAuthService.php+1 −1
- typo3/sysext/rsaauth/Classes/RsaEncryptionDecoder.php+3 −3
- typo3/sysext/rsaauth/Classes/RsaEncryptionEncoder.php+1 −1
- typo3/sysext/rsaauth/Tests/Unit/KeypairTest.php+1 −1
- typo3/sysext/saltedpasswords/Classes/Salt/SaltFactory.php+1 −1
- typo3/sysext/saltedpasswords/Classes/SaltedPasswordService.php+1 −1
- typo3/sysext/saltedpasswords/Tests/Unit/Salt/BlowfishSaltTest.php+1 −1
- typo3/sysext/saltedpasswords/Tests/Unit/Salt/Md5SaltTest.php+1 −1
- typo3/sysext/saltedpasswords/Tests/Unit/Salt/Pbkdf2SaltTest.php+1 −1
- typo3/sysext/saltedpasswords/Tests/Unit/Salt/PhpassSaltTest.php+1 −1
- typo3/sysext/saltedpasswords/Tests/Unit/Salt/SaltFactoryTest.php+1 −1
- typo3/sysext/workspaces/Classes/Service/GridDataService.php+2 −2
Review log 67
-
Wouter Wolters uploaded patch set 1 06/17/18, 14:19
-
TYPO3com voted on patch set 1 V +1 06/17/18, 14:28 Completed build in 08m 34s on Sun, 17 Jun, 04:28 PM Test Summary: 32702 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-24518
-
Alexander Schnitzler voted on patch set 1 CR +1 06/18/18, 08:01
-
Jigal van Hemert voted on patch set 1 CR +1 06/21/18, 13:39
-
Stefan Neufeind voted on patch set 1 V +1 CR +1 06/22/18, 19:02
-
Andreas Kienast voted on patch set 1 V +2 CR +2 06/22/18, 19:55
-
Andreas Kienast merged patch set 2 06/22/18, 19:55