Review main Merged

57245[TASK] Replace array_push with normal array assignment

Wouter Wolters CR +2 V +2 Easy +2 −2 updated 06/18/18, 04:40

Commit message

Direct array assignment works faster than invoking php functions

Review

  • Code review CR +2
    • Benni Mack +2
    • Oliver Klee +1
    • Susi Moog +1
  • Verified V +2
    • Benni Mack +2
    • Susi Moog +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 56

  1. Wouter Wolters uploaded patch set 1 06/17/18, 14:40

  2. TYPO3com voted on patch set 1 V +1 06/17/18, 14:48 Completed build in 08m 22s on Sun, 17 Jun, 04:48 PM Test Summary: 32702 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-24521

  3. Susi Moog voted on patch set 1 V +1 CR +1 06/17/18, 15:16

  4. Oliver Klee voted on patch set 1 CR +1 06/17/18, 16:16

  5. Benni Mack voted on patch set 1 V +2 CR +2 06/18/18, 04:40

  6. Benni Mack merged patch set 2 06/18/18, 04:40