57246[TASK] Merge str_replace calls when applied to a variable sequentially
Commit message
Review
-
Code review CR +2
- Benni Mack +2
- Stefan Bürk +1
- Susi Moog +1
-
Verified V +2
- Benni Mack +2
- Stefan Bürk +1
- Susi Moog +1
- TYPO3com +1 CI
Issues 1
Files 10
- typo3/sysext/backend/Classes/Controller/Wizard/TableController.php+3 −3
- typo3/sysext/backend/Tests/Unit/Form/FormDataProvider/TcaSelectItemsTest.php+1 −1
- typo3/sysext/core/Classes/Utility/ArrayUtility.php+1 −2
- typo3/sysext/extbase/Classes/Property/TypeConverter/FloatConverter.php+1 −2
- typo3/sysext/fluid/Classes/ViewHelpers/Debug/RenderViewHelper.php+1 −2
- typo3/sysext/frontend/Classes/Controller/TypoScriptFrontendController.php+1 −2
- typo3/sysext/frontend/Tests/Functional/ContentObject/ContentObjectRendererTest.php+1 −2
- typo3/sysext/frontend/Tests/Unit/ContentObject/ContentObjectRendererTest.php+5 −20
- typo3/sysext/install/Classes/Service/LocalConfigurationValueService.php+1 −2
- typo3/sysext/rte_ckeditor/Classes/Controller/BrowseLinksController.php+1 −1
Review log 79
-
Wouter Wolters uploaded patch set 1 06/17/18, 14:45
-
TYPO3com voted on patch set 1 V -1 06/17/18, 14:45 Completed build in 10s on Sun, 17 Jun, 04:45 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-24522
-
Wouter Wolters uploaded patch set 2 06/17/18, 14:46
-
TYPO3com voted on patch set 2 V +1 06/17/18, 14:55 Completed build in 09m 38s on Sun, 17 Jun, 04:55 PM Test Summary: 32702 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-24523
-
Susi Moog voted on patch set 2 CR +1 06/17/18, 15:07
-
Susi Moog voted on patch set 2 V +1 06/17/18, 15:15
-
Stefan Bürk voted on patch set 2 V +1 CR +1 06/17/18, 15:45
-
Benni Mack voted on patch set 2 V +2 CR +2 06/18/18, 05:02
-
Benni Mack merged patch set 3 06/18/18, 05:02