Review main Merged

57247[BUGFIX] Cast database result uid to int

Susi Moog CR +2 V +2 Easy +2 −2 updated 06/19/18, 10:48

Commit message

As the OrphanRecordsCommand is using strict types
the results in row['uid'] has been casted to int
before usage in further methods as it is returned
as string from the database.

Review

  • Code review CR +2
    • Tymoteusz Motylewski +2
    • Georg Ringer +1
    • Oliver Klee +1
    • Wouter Wolters +1
  • Verified V +2
    • Tymoteusz Motylewski +2
    • Georg Ringer +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 67

  1. Susi Moog uploaded patch set 1 06/17/18, 14:48

  2. Wouter Wolters voted on patch set 1 CR +1 06/17/18, 14:53

  3. TYPO3com voted on patch set 1 V +1 06/17/18, 14:57 Completed build in 08m 33s on Sun, 17 Jun, 04:57 PM Test Summary: 32702 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-24524

  4. Oliver Klee voted on patch set 1 CR +1 06/17/18, 16:17

  5. Georg Ringer voted on patch set 1 V +1 CR +1 06/18/18, 16:54

  6. Tymoteusz Motylewski voted on patch set 1 V +2 CR +2 06/19/18, 10:48

  7. Tymoteusz Motylewski merged patch set 2 06/19/18, 10:48