Review main Merged

57248[TASK] Replace nested dirname calls with using the levels parameter

Wouter Wolters CR +2 V +2 Easy +3 −3 updated 06/22/18, 19:40

Commit message

Review

  • Code review CR +2
    • Georg Ringer +2
    • Stefan Neufeind +1
    • Andreas Kienast +1
    • Jigal van Hemert +1
    • Susi Moog +1
  • Verified V +2
    • Georg Ringer +2
    • Stefan Neufeind +1
    • TYPO3com +1 CI

Issues 1

Files 3

Review log 89

  1. Wouter Wolters uploaded patch set 1 06/17/18, 14:57

  2. TYPO3com voted on patch set 1 V +1 06/17/18, 15:06 Completed build in 08m 35s on Sun, 17 Jun, 05:06 PM Test Summary: 32702 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-24525

  3. Susi Moog voted on patch set 1 CR +1 06/17/18, 15:16

  4. Andreas Kienast voted on patch set 1 CR +1 06/18/18, 06:39

  5. Jigal van Hemert voted on patch set 1 CR +1 06/21/18, 13:51

  6. Stefan Neufeind voted on patch set 1 CR +1 06/22/18, 18:59

  7. Stefan Neufeind commented on patch set 1 V +1 06/22/18, 19:01

    checked that these are the only places for nested dirname-calls
  8. Georg Ringer voted on patch set 1 V +2 CR +2 06/22/18, 19:40

  9. Georg Ringer merged patch set 2 06/22/18, 19:40